-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Network] #88 - Mypage api 연결 #94
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
내 기분이 좋소이다.
@@ -97,6 +82,15 @@ final class HankkiListViewController: BaseViewController { | |||
} | |||
|
|||
private extension HankkiListViewController { | |||
private func setupViewModel() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3: bindViewModel
은 어떠하시오?
extension HankkiListViewModel { | ||
func getMeHankkiList(_ type: UserTargetType, completion: @escaping (Bool) -> Void) { | ||
NetworkService.shared.userService.getMeHankkiList(type) { result in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type 아주 좋소
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APPLETV
struct GetMeHankkiHeartListResponseData: Codable { | ||
let stored: [GetMeHankkiHeartResponseData] | ||
struct GetMeHankkiListResponseData: Codable { | ||
let stores: [GetMeHankkiResponseData] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3
GetHankkiListData가 어떠할까요 아가낭자공주님
} | ||
|
||
struct GetMeHankkiHeartResponseData: Codable { | ||
struct GetMeHankkiResponseData: Codable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3
네이밍컨벤션 부탁드리옵나이다 아기님
|
||
var userTargetType: UserTargetType { | ||
switch self { | ||
case .repoted: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3
오타인 것 같소
extension MypageHeaderView { | ||
struct DataStruct { | ||
let image: UIImage | ||
let name: String | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3
Model 로 분리해주세요
🔥 Pull requests
👷 작업한 내용
🚨 참고 사항
Header Type 을 지정합니다.
login Header의 경우
Bearer
을 붙이지 않기 위해 별도로 헤더를 선택합니다.필요한 헤더 타입이 있다면 추가해서 작성해주세요.
📸 스크린샷
🖥️ 주요 코드 설명
HankkiListViewModel.swift
식당 리스트의 경우, 같은 뷰와, Data를 쓰기 때문에, .type으로 다른 API 를 호출할 수 있도록 설정했습니다.
✅ Check List
📟 관련 이슈