Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control the lights on the gamepad using Serial #1

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Control the lights on the gamepad using Serial #1

wants to merge 5 commits into from
+92 −34

Conversation

stephenjust
Copy link

@stephenjust stephenjust commented Feb 2, 2024 •
edited
Loading

aschokking
aschokking approved these changes Feb 2, 2024
View reviewed changes
code_1.py Outdated Show resolved Hide resolved
code_1.py Outdated
greenValue = int(commandString[5:8])
blueValue = int(commandString[8:11])
if not inRange(ledNumber, 1, 32):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these really not 0 indexed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it this way to match the buttons, which start at 1 per the USB spec.

JohnGilb
JohnGilb approved these changes Feb 2, 2024
View reviewed changes
deploy.cmd
for /f %%D in ('wmic volume get DriveLetter^, Label ^| find "CIRCUITPY"') do set myDrive=%%D
echo %myDrive%

set myDrive=D:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened here? Did deploy.cmd not find the CIRCUITPY drive on your machine? Did it show up with a different name?

@stephenjust
Copy link
Author

stephenjust commented Feb 2, 2024 via email

@JohnGilb
Copy link
Contributor

JohnGilb commented Feb 2, 2024 •
edited
Loading

Huh, no clue. It doesn't make too much difference; we can mess with it later to see if there's some way to make it reliable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschokking aschokking aschokking approved these changes

@JohnGilb JohnGilb JohnGilb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephenjust @JohnGilb @aschokking