Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate keybind #33

Merged
merged 1 commit into from
Aug 25, 2024
Merged

Remove duplicate keybind #33

merged 1 commit into from
Aug 25, 2024

Conversation

Alexdoru
Copy link
Contributor

There are two identical keybinds regitered and they do the same thing, so I removed one of them

remove one of two keybinds that does the same thing : "Switch between Day/Night/Caves"

@CLAassistant
Copy link

CLAassistant commented Aug 24, 2024

CLA assistant check
All committers have signed the CLA.

@Alexdoru
Copy link
Contributor Author

what is this thing, I ain't clicking any link that's asking for access to my github account

@mysticdrew
Copy link
Member

mysticdrew commented Aug 24, 2024

what is this thing, I ain't clicking any link that's asking for access to my github account

It is the cla, contributor license agreement. It must be signed before I can merge your pr.
https://cla-assistant.io/
a lot of opensource projects use this to protect their code for situation like the bukkit dmca issue.
https://www.spigotmc.org/wiki/unofficial-explanation-about-the-dmca/

Both Forge and Neoforge also use it.

Copy link
Member

@mysticdrew mysticdrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, not sure why it was done that way. Will merge once the cla is signed.

@Alexdoru
Copy link
Contributor Author

I signed

@mysticdrew
Copy link
Member

thank you

@mysticdrew mysticdrew merged commit 6c82a24 into TeamJM:master Aug 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants