Add Retrofit plugin (#445)

* Add Retrofit plugin * Change import of serializaition converter factory * Remove redundant
TeamPophory · Mar 22, 2024 · ac9683a · ac9683a
1 parent db8ba51
commit ac9683a
Show file tree

Hide file tree

Showing 13 changed files with 33 additions and 13 deletions.
diff --git a/.idea/.gitignore b/.idea/.gitignore
diff --git a/app/build.gradle.kts b/app/build.gradle.kts
@@ -102,7 +102,6 @@ dependencies {
     // Third Party
     implementation(libs.dot.indicator)
     implementation(libs.coil.core)
-    implementation(libs.bundles.retrofit)
     implementation(libs.kakao.login)
     implementation(libs.zxing.android.embedded)
 

diff --git a/build-logic/convention/build.gradle.kts b/build-logic/convention/build.gradle.kts
@@ -48,5 +48,9 @@ gradlePlugin {
             id = "com.teampophory.pophory.compose"
             implementationClass = "com.teampophory.pophory.plugin.ComposePlugin"
         }
+        create("retrofit") {
+            id = "com.teampophory.pophory.retrofit"
+            implementationClass = "com.teampophory.pophory.plugin.RetrofitPlugin"
+        }
     }
 }
diff --git a/build-logic/convention/src/main/kotlin/com/teampophory/pophory/plugin/CommonConfigs.kt b/build-logic/convention/src/main/kotlin/com/teampophory/pophory/plugin/CommonConfigs.kt
@@ -15,6 +15,7 @@ internal fun Project.configureAndroidCommonPlugin() {
 
     apply<AndroidKotlinPlugin>()
     apply<KotlinSerializationPlugin>()
+    apply<RetrofitPlugin>()
     with(plugins) {
         apply("kotlin-parcelize")
     }

diff --git a/build-logic/convention/src/main/kotlin/com/teampophory/pophory/plugin/RetrofitPlugin.kt b/build-logic/convention/src/main/kotlin/com/teampophory/pophory/plugin/RetrofitPlugin.kt
@@ -0,0 +1,20 @@
+package com.teampophory.pophory.plugin
+
+import org.gradle.api.Plugin
+import org.gradle.api.Project
+import org.gradle.api.artifacts.VersionCatalogsExtension
+import org.gradle.kotlin.dsl.dependencies
+import org.gradle.kotlin.dsl.getByType
+
+class RetrofitPlugin : Plugin<Project> {
+    override fun apply(target: Project) = with(target) {
+        val libs = extensions.getByType<VersionCatalogsExtension>().named("libs")
+
+        dependencies {
+            "implementation"(platform(libs.findLibrary("retrofit-bom").get()))
+            "implementation"(libs.findLibrary("retrofit").get())
+            "implementation"(libs.findLibrary("retrofit-kotlin-serialization-converter").get())
+            "implementation"(libs.findLibrary("retrofit-response-type-keeper").get())
+        }
+    }
+}
diff --git a/core/common/build.gradle.kts b/core/common/build.gradle.kts
@@ -13,5 +13,4 @@ android {
 
 dependencies {
     implementation(libs.fragment.ktx)
-    implementation(libs.retrofit)
 }
diff --git a/core/network/build.gradle.kts b/core/network/build.gradle.kts
@@ -10,7 +10,6 @@ android {
 dependencies {
     implementation(projects.core.common)
     implementation(libs.security)
-    implementation(libs.bundles.retrofit)
     implementation(platform(libs.okhttp.bom))
     implementation(libs.okhttp.logging.interceptor)
     implementation(libs.kakao.login)

diff --git a/core/network/src/main/java/com/teampophory/pophory/network/di/NetModule.kt b/core/network/src/main/java/com/teampophory/pophory/network/di/NetModule.kt
@@ -1,6 +1,5 @@
 package com.teampophory.pophory.network.di
 
-import com.jakewharton.retrofit2.converter.kotlinx.serialization.asConverterFactory
 import com.teampophory.pophory.common.qualifier.Auth
 import com.teampophory.pophory.common.qualifier.Log
 import com.teampophory.pophory.common.qualifier.Secured
@@ -22,6 +21,7 @@ import okhttp3.OkHttpClient
 import okhttp3.logging.HttpLoggingInterceptor
 import retrofit2.Converter
 import retrofit2.Retrofit
+import retrofit2.converter.kotlinx.serialization.asConverterFactory
 import java.util.concurrent.TimeUnit
 import javax.inject.Singleton
 

diff --git a/data/ad/build.gradle.kts b/data/ad/build.gradle.kts
@@ -12,6 +12,5 @@ dependencies {
     implementation(projects.core.common)
     implementation(projects.core.network)
     implementation(libs.security)
-    implementation(libs.bundles.retrofit)
     implementation(libs.sentry)
 }
diff --git a/data/auth/build.gradle.kts b/data/auth/build.gradle.kts
@@ -12,7 +12,6 @@ dependencies {
     implementation(projects.core.common)
     implementation(projects.core.network)
     implementation(libs.security)
-    implementation(libs.bundles.retrofit)
     implementation(libs.process.phoenix)
     implementation(libs.sentry)
 }
diff --git a/data/share/build.gradle.kts b/data/share/build.gradle.kts
@@ -10,5 +10,4 @@ dependencies {
     implementation(projects.domain.share)
     implementation(projects.core.common)
     implementation(projects.core.network)
-    implementation(libs.bundles.retrofit)
 }
diff --git a/feature/share/build.gradle.kts b/feature/share/build.gradle.kts
@@ -28,5 +28,4 @@ dependencies {
 
     // Third Party
     implementation(libs.coil.core)
-    implementation(libs.retrofit)
 }
diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
@@ -8,7 +8,6 @@ versionCode = "10200"
 # kotlin
 kotlin = "1.9.23"
 kotlinx-serialization-json = "1.6.3"
-kotlinx-serialization-converter = "1.0.0"
 kotlinx-coroutines = "1.8.0"
 kotlinx-datetime = "0.5.0"
 
@@ -67,7 +66,7 @@ kspplugin = "1.9.23-1.0.19"
 flipper = "0.250.0"
 soloader = "0.11.0"
 okhttp = "4.12.0"
-retrofit = "2.9.0"
+retrofit = "2.10.0"
 timber = "5.0.1"
 coil = "2.6.0"
 lottie = "6.0.1"
@@ -179,8 +178,10 @@ okhttp-bom = { module = "com.squareup.okhttp3:okhttp-bom", version.ref = "okhttp
 okhttp = { module = "com.squareup.okhttp3:okhttp" }
 okhttp-logging-interceptor = { module = "com.squareup.okhttp3:logging-interceptor" }
 
-retrofit = { module = "com.squareup.retrofit2:retrofit", version.ref = "retrofit" }
-retrofit-kotlin-serialization-converter = { group = "com.jakewharton.retrofit", name = "retrofit2-kotlinx-serialization-converter", version.ref = "kotlinx-serialization-converter" }
+retrofit-bom = { module = "com.squareup.retrofit2:retrofit-bom", version.ref = "retrofit" }
+retrofit = { module = "com.squareup.retrofit2:retrofit" }
+retrofit-kotlin-serialization-converter = { group = "com.squareup.retrofit2", name = "converter-kotlinx-serialization" }
+retrofit-response-type-keeper = { module = "com.squareup.retrofit2:response-type-keeper" }
 
 timber = { module = "com.jakewharton.timber:timber", version.ref = "timber" }
 
@@ -220,6 +221,5 @@ firebase = ["firebase-analytics", "firebase-crashlytics", "firebase-dynamiclink"
 flipper = ["flipper", "soloader", "flipper-network"]
 lifecycle = ["lifecycle", "lifecycle-viewmodel", "lifecycle-livedata"]
 compose = ["ui", "ui-graphics", "ui-tooling", "ui-tooling-preview", "material3-compose", "coil-compose", "ui-foundation", "activity-compose", "lifecycle-compose", "navigation-compose"]
-retrofit = ["retrofit", "retrofit-kotlin-serialization-converter"]
 junit5 = ["junit5", "junit5-engine", "junit5-params", "junit5-vintage", "junit5-android-test-core", "junit5-android-test-runner"]
 androidx-android-test = ["androidx-test-core", "androidx-test-espresso", "androidx-test-espresso-intents", "androidx-test-junit", "androidx-test-junit-ktx", "androidx-test-rules", "androidx-test-runner", "androidx-test-truth"]