Feature refactor signup #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l2hyunwoo
requested changes
Jul 14, 2023
| @@ -16,98 +23,167 @@ import dagger.hilt.android.AndroidEntryPoint | |||
| class SignUpActivity : AppCompatActivity() { | |||
|
|
|||
| private val binding by viewBinding(ActivitySignUpBinding::inflate) | |||
| //TODO 수정 필요 | |||
app/src/main/java/com/teampophory/pophory/feature/signup/SignUpActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/teampophory/pophory/feature/signup/SignUpFirstFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/teampophory/pophory/feature/signup/SignUpViewModel.kt
Outdated
Show resolved
Hide resolved
|
아직 코드 수정중인 것 같아서 Draft 걸겠습니다 @jihyeonAnAn |
kez-lab
reviewed
Jul 14, 2023
Comment on lines
82
to
58
| when (currentFragment) { | ||
| SIGN_UP_FIRST_FRAGMENT -> { | ||
| navController.navigate(R.id.action_signUpFirstFragment_to_signUpSecondFragment) | ||
| } | ||
| SIGN_UP_SECOND_FRAGMENT -> { | ||
| navController.navigate(R.id.action_signUpSecondFragment_to_signUpThirdFragment) | ||
| } | ||
| SIGN_UP_THIRD_FRAGMENT -> { | ||
| val intent = Intent(this, StartPophoryActivity::class.java) | ||
| startActivity(intent) | ||
| } | ||
| } |
There was a problem hiding this comment.
워후 enum과 when문이라니 이젠 절정 고수의 반열에 들었구나 지현아...
| @@ -66,6 +67,7 @@ class SignUpFirstFragment : Fragment() { | |||
| doAfterTextChanged { | |||
|
|
|||
| signUpViewModel.setRealName(it.toString()) | |||
| signUpViewModel.setButtonState(!binding.editTvName.text.isNullOrEmpty() && !binding.tvErrorMessage.isVisible) | |||
There was a problem hiding this comment.
여기 Boolean값을 반환하는 함수로 따로 빼면 가독성이 더 좋아질 것 같아요
librarywon
reviewed
Jul 14, 2023
Comment on lines
82
to
58
| when (currentFragment) { | ||
| SIGN_UP_FIRST_FRAGMENT -> { | ||
| navController.navigate(R.id.action_signUpFirstFragment_to_signUpSecondFragment) | ||
| } | ||
| SIGN_UP_SECOND_FRAGMENT -> { | ||
| navController.navigate(R.id.action_signUpSecondFragment_to_signUpThirdFragment) | ||
| } | ||
| SIGN_UP_THIRD_FRAGMENT -> { | ||
| val intent = Intent(this, StartPophoryActivity::class.java) | ||
| startActivity(intent) | ||
| } | ||
| } |
Comment on lines
97
to
96
| companion object { | ||
| const val SIGN_UP_FIRST_FRAGMENT = "SignUpFirstFragment" | ||
| const val SIGN_UP_SECOND_FRAGMENT = "SignUpSecondFragment" | ||
| const val SIGN_UP_THIRD_FRAGMENT = "SignUpThirdFragment" | ||
| } |
| android:id="@+id/viewpager" | ||
| <androidx.fragment.app.FragmentContainerView | ||
| android:id="@+id/nav_host_fragment" |
There was a problem hiding this comment.
nav_sign_up_fragment는 어떤가요?
Comment on lines
46
to
50
| //다음 버튼 | ||
| setOnClickNextButton() | ||
| //툴바 뒤로 가기 버튼 | ||
| setOnToolbarBackPressed() | ||
| //기기 뒤로 가기 버튼 |
There was a problem hiding this comment.
친절한 주석 때문에 가독성이 진짜 좋아지는 것 같습니다!
jihyeonAnAn
force-pushed
the
feature_refactor_signup
branch
from
c159fd0
to
e6f5b75
Compare
jihyeonAnAn
force-pushed
the
feature_refactor_signup
branch
3 times, most recently
from
49d7fcc
to
6fc971a
Compare
l2hyunwoo
requested changes
Jul 19, 2023
| fun setSignUpButtonInterface(buttonState: OnButtonStateChangeListener) { | ||
| this.buttonState = buttonState | ||
| private fun setEditTextState( | ||
| background: Int, |
There was a problem hiding this comment.
Suggested change
| background: Int, | |
| @DrawableRes background: Int, |
| @@ -10,7 +10,7 @@ import com.teampophory.pophory.feature.signup.SignUpThirdFragment | |||
|
|
|||
| class SignUpViewPagerAdapter( | |||
| fragmentActivity: FragmentActivity, | |||
| private val buttonState: OnButtonStateChangeListener | |||
| //private val buttonState: OnButtonStateChangeListener | |||
| @@ -19,13 +19,13 @@ class SignUpViewPagerAdapter( | |||
| return when (position) { | |||
| 0 -> { | |||
| SignUpFirstFragment().apply { | |||
| setSignUpButtonInterface(buttonState) | |||
| //setSignUpButtonInterface(buttonState) | |||
| } | ||
| } | ||
|
|
||
| 1 -> { | ||
| SignUpSecondFragment().apply { | ||
| setSignUpButtonInterface(buttonState) | ||
| //setSignUpButtonInterface(buttonState) |
There was a problem hiding this comment.
위에도 그렇고 이것도 보니까 그냥 apply 삭제해도 될듯?
jihyeonAnAn
force-pushed
the
feature_refactor_signup
branch
from
93f979e
to
773c3fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 코드
📸 스크린샷
🍀 관련 이슈
우선 navigation으로 변경했고 navigation viewmodel 사용하면서 추가 수정 예정