[Feature/mypage] 2차 스프린트 mypage 수정 #158

librarywon · 2023-07-14T06:16:04Z

이슈 코드

📸 스크린샷

🍀 관련 이슈

2차 api가 나오면 네트워크 관련 로직도 수정하겠습니다!
프로필 뒤에 배경은 아직 임시로 넣은 이미지입니다. 추후 일러스트가 완성되면 교체할 예정입니다.

kez-lab

LGTM🍀 고생하셨습니다. 수정만 하고 머지 부탁드려욥

kez-lab · 2023-07-15T06:46:51Z

app/src/main/res/layout/fragment_mypage.xml

+        android:id="@+id/iv_mypage_profile"
+        android:layout_width="72dp"
+        android:layout_height="72dp"
+        android:layout_marginTop="66dp"


dimentionRatio 도 활용하면 좋을 것 같네욥

넵 그게 좋을 것 같네요 반영하겠습니다!

kez-lab · 2023-07-15T06:53:33Z

app/src/main/res/layout/fragment_mypage.xml

+        <ImageView
+            android:id="@+id/iv_mypage_story_ic"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:src="@drawable/ic_chevron_right"
+            app:layout_constraintBottom_toBottomOf="@id/tv_mypage_story_title"
+            app:layout_constraintStart_toEndOf="@id/tv_mypage_story_title"
+            app:layout_constraintTop_toTopOf="@id/tv_mypage_story_title" />


이미지뷰는 왠만하면 고정 크기를 잡아주는게 좋아욥!! 디자이너측에서 잘못 전달할리는 없지만 간혹 서버 이미지로 변경될때 크기 변경이 일어나며 뷰가 깨집니당

아 그럴수가 있군요 고정크기를 잡아서 반영하겠습니다 ㅎㅎ

kez-lab · 2023-07-15T06:55:03Z

app/src/main/java/com/teampophory/pophory/feature/home/mypage/MyPageFragment.kt

+    private fun setOnClickListener() {
+        with(binding) {
+            //setting 이동
+            ivToolbarSetting.setOnClickListener {
+                startActivity(Intent(requireContext(), SettingActivity::class.java))
            }
-        }
-
-        gridLayoutManager.spanSizeLookup = object : GridLayoutManager.SpanSizeLookup() {
-            override fun getSpanSize(position: Int): Int {
-                return when (myPageAdapter?.getItemViewType(position)) {
-                    VIEW_TYPE_PROFILE -> 3
-                    VIEW_TYPE_PHOTO -> 1
-                    VIEW_TYPE_EMPTY -> 3
-                    else -> 1
-                }
+            //share 이동
+            layoutMypageShare.setOnClickListener{
+                //TODO Intent to Share
+            }
+            //stroy 이동
+            layoutMypageStory.setOnClickListener{
+                //TODO Intent to Story


l2hyunwoo

색상값만 잘 수정하면 머지 바로 가능할 듯

l2hyunwoo · 2023-07-15T07:56:37Z

app/src/main/java/com/teampophory/pophory/feature/home/mypage/MyPageFragment.kt

-                AlbumDetailActivity.newIntent(requireContext(), photos.photo).let(::startActivity)
+    private fun setOnClickListener() {
+        with(binding) {
+            //setting 이동


주석 삭제 plz

l2hyunwoo · 2023-07-15T07:57:31Z

app/src/main/res/drawable/bg_round_16dp_gray20.xml

+<shape android:shape="rectangle"
+    xmlns:android="http://schemas.android.com/apk/res/android">
+    <corners android:radius="16dp"/>
+    <solid android:color="@color/gray_20"/>


?colorOnSurface20

반영하겠습니다!

l2hyunwoo · 2023-07-15T07:57:59Z

app/src/main/res/layout/fragment_mypage.xml

        android:layout_width="match_parent"
-        android:layout_height="0dp"
+        android:layout_height="124dp"
+        android:background="#EBE8FF"


이것도 테마에서 색상찾아가지고 적용하면 좋을 것 같아

일러스트가 들어올 영역을 잡아둔 친구라서 일러스트가 들어오면 삭제 예정입니다!

l2hyunwoo · 2023-07-15T07:59:28Z

app/src/main/res/layout/fragment_mypage.xml

+            android:layout_width="114dp"
+            android:layout_height="103dp"


wrap_content나 parent에 margin 걸어서 해결할 순 없을까?

해결해보겠습니다!

l2hyunwoo · 2023-07-15T08:00:18Z

app/src/main/res/layout/fragment_mypage.xml

@@ -13,6 +13,7 @@
        android:background="?colorSurface"
        app:layout_constraintBottom_toTopOf="@id/div_mypage"
        app:layout_constraintEnd_toEndOf="parent"
+        app:layout_constraintHorizontal_bias="0.0"


이 친구 강제로 넣은건가요?

자동으로 추가된 부분 같습니다 삭제하겠습니다!

l2hyunwoo · 2023-07-17T12:37:34Z

app/src/main/java/com/teampophory/pophory/feature/home/mypage/MyPageFragment.kt

@@ -58,7 +59,8 @@ class MyPageFragment : Fragment() {
                    hideLoading()
                    with(binding) {
                        val profile = myPageInfoState.data
-                        tvMypageToolbarNickname.text = "@${profile.nickname}"
+                        toast(myPageInfoState.data.toString())


이거 테스트 한거 때문이면 마지막에 삭제하자

넵 삭제하였습니다!

l2hyunwoo · 2023-07-17T17:12:04Z

app/src/main/java/com/teampophory/pophory/data/network/model/mypage/MyPageResponse.kt

+    val photoCount: Int
+) {
+    fun toProfile(): Profile {
+        return Profile(id,realName, nickname, profileImageUrl,photoCount)


l2hyunwoo · 2023-07-17T17:12:43Z

app/src/main/java/com/teampophory/pophory/feature/home/mypage/MyPageFragment.kt

+            layoutMypageShare.setOnClickListener {
+                //TODO Intent to Share
+            }
+            //stroy 이동
+            layoutMypageStory.setOnClickListener {
+                //TODO Intent to Story


이거 먼저 머지하고 공유하기를 나중에 올려야하겠네

l2hyunwoo

👍🏻

librarywon added 🦈서재원 서재원이 했다 ✨ Feature 기능 개발 labels Jul 14, 2023

librarywon requested a review from a team as a code owner July 14, 2023 06:16

librarywon self-assigned this Jul 14, 2023

kez-lab approved these changes Jul 15, 2023

View reviewed changes

l2hyunwoo requested changes Jul 15, 2023

View reviewed changes

librarywon added 6 commits July 16, 2023 16:34

[feature/mypage]: UI refactor

8880e14

[feature/mypage]: refactor for sprint no.2

fdc375b

[feature/mypage]: refactor 2차 수정된 디자인을 반영

9e04b05

[feature/mypage]: refactor adapter 삭제, 데이터 통신 로직 수정

55d5650

[feature/mypage]: add share image

31d5628

[feature/mypage]: refactor PR 1차 대응

a18206c

librarywon force-pushed the feature/mypage branch from d8e36fd to a18206c Compare July 16, 2023 07:35

l2hyunwoo marked this pull request as draft July 16, 2023 07:47

l2hyunwoo added this to the v1.1.0 milestone Jul 16, 2023

[feature/share]: migration for V2

80810e0

l2hyunwoo reviewed Jul 17, 2023

View reviewed changes

librarywon added 2 commits July 17, 2023 22:29

[feature/store]: chore remove test code

a6c1bcc

[feature/store]: dataSource 삭제, data/network로 이식

b96b034

l2hyunwoo reviewed Jul 17, 2023

View reviewed changes

l2hyunwoo approved these changes Jul 17, 2023

View reviewed changes

librarywon marked this pull request as ready for review July 17, 2023 17:58

librarywon merged commit 502c5d3 into develop Jul 18, 2023

librarywon deleted the feature/mypage branch July 18, 2023 16:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature/mypage] 2차 스프린트 mypage 수정 #158

[Feature/mypage] 2차 스프린트 mypage 수정 #158

librarywon commented Jul 14, 2023 •

edited

Loading

kez-lab left a comment

kez-lab Jul 15, 2023

librarywon Jul 15, 2023

kez-lab Jul 15, 2023

librarywon Jul 15, 2023

kez-lab Jul 15, 2023

l2hyunwoo left a comment

l2hyunwoo Jul 15, 2023

librarywon Jul 15, 2023

l2hyunwoo Jul 15, 2023

librarywon Jul 15, 2023

l2hyunwoo Jul 15, 2023

librarywon Jul 15, 2023

l2hyunwoo Jul 15, 2023

librarywon Jul 15, 2023

l2hyunwoo Jul 15, 2023

librarywon Jul 15, 2023

l2hyunwoo Jul 17, 2023

librarywon Jul 17, 2023

l2hyunwoo Jul 17, 2023

l2hyunwoo Jul 17, 2023

l2hyunwoo left a comment

[Feature/mypage] 2차 스프린트 mypage 수정 #158

[Feature/mypage] 2차 스프린트 mypage 수정 #158

Conversation

librarywon commented Jul 14, 2023 • edited Loading

이슈 코드

📸 스크린샷

🍀 관련 이슈

kez-lab left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

l2hyunwoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

l2hyunwoo left a comment

Choose a reason for hiding this comment

librarywon commented Jul 14, 2023 •

edited

Loading