Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/photo detail-UI] 2차 스프린트 photo detail migration 및 ui 수정 #184

Merged
merged 4 commits into from
Jul 18, 2023

Conversation

librarywon
Copy link
Contributor

@librarywon librarywon added 🦈서재원 서재원이 했다 ✨ Feature 기능 개발 labels Jul 18, 2023
@librarywon librarywon added this to the v1.1.0 milestone Jul 18, 2023
@librarywon librarywon requested a review from a team as a code owner July 18, 2023 16:54
@librarywon librarywon self-assigned this Jul 18, 2023
@librarywon librarywon changed the title Feature/photo detail UI [Feature/photo detail-UI] 2차 스프린트 photo detail migration 및 ui 수정 Jul 18, 2023
Comment on lines 40 to 62
<ImageView
android:id="@+id/ivAlbumDelete"
android:layout_width="48dp"
android:layout_height="48dp"
android:layout_marginVertical="21dp"
android:layout_marginEnd="8dp"
android:padding="12dp"
android:layout_width="24dp"
android:layout_height="24dp"
android:layout_marginEnd="14dp"
android:src="@drawable/ic_bin_empty"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toStartOf="@id/ivAlbumShare"
app:layout_constraintTop_toTopOf="parent" />

<ImageView
android:id="@+id/ivAlbumShare"
android:layout_width="24dp"
android:layout_height="24dp"
android:layout_marginEnd="20dp"
android:src="@drawable/ic_share"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintTop_toTopOf="parent" />


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

48dp로 변경 부탁드립니다

@librarywon librarywon merged commit eb57167 into develop Jul 18, 2023
@librarywon librarywon deleted the feature/photo-detail-ui branch July 18, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 개발 🦈서재원 서재원이 했다
Projects
None yet
3 participants