-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature/photo detail-UI] 2차 스프린트 photo detail migration 및 ui 수정 #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librarywon
changed the title
Feature/photo detail UI
[Feature/photo detail-UI] 2차 스프린트 photo detail migration 및 ui 수정
Jul 18, 2023
l2hyunwoo
approved these changes
Jul 18, 2023
kez-lab
approved these changes
Jul 18, 2023
Comment on lines
40
to
62
<ImageView | ||
android:id="@+id/ivAlbumDelete" | ||
android:layout_width="48dp" | ||
android:layout_height="48dp" | ||
android:layout_marginVertical="21dp" | ||
android:layout_marginEnd="8dp" | ||
android:padding="12dp" | ||
android:layout_width="24dp" | ||
android:layout_height="24dp" | ||
android:layout_marginEnd="14dp" | ||
android:src="@drawable/ic_bin_empty" | ||
app:layout_constraintBottom_toBottomOf="parent" | ||
app:layout_constraintEnd_toStartOf="@id/ivAlbumShare" | ||
app:layout_constraintTop_toTopOf="parent" /> | ||
|
||
<ImageView | ||
android:id="@+id/ivAlbumShare" | ||
android:layout_width="24dp" | ||
android:layout_height="24dp" | ||
android:layout_marginEnd="20dp" | ||
android:src="@drawable/ic_share" | ||
app:layout_constraintBottom_toBottomOf="parent" | ||
app:layout_constraintEnd_toEndOf="parent" | ||
app:layout_constraintTop_toTopOf="parent" /> | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
48dp로 변경 부탁드립니다
librarywon
force-pushed
the
feature/photo-detail-ui
branch
from
July 18, 2023 17:27
a673d1a
to
15fd45a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 코드
🍀 관련 이슈