Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature/qr_qa] 3차 스프린트 QR관련 qa 대응 #321

Merged
merged 4 commits into from
Oct 26, 2023
Merged

[Feature/qr_qa] 3차 스프린트 QR관련 qa 대응 #321

merged 4 commits into from
Oct 26, 2023

Conversation

librarywon
Copy link
Contributor

이슈 코드

📸 스크린샷

KakaoTalk_Video_2023-10-26-02-15-46.mp4

🍀 관련 이슈

  • QA 대응 완료했습니당

@librarywon librarywon added 🐞 BugFix Something isn't working 🦈서재원 서재원이 했다 ✨ Feature 기능 개발 labels Oct 25, 2023
@librarywon librarywon self-assigned this Oct 25, 2023
@librarywon librarywon requested a review from a team as a code owner October 25, 2023 17:16
@l2hyunwoo l2hyunwoo changed the base branch from develop to release/1.2.0 October 26, 2023 00:22
l2hyunwoo
l2hyunwoo approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@l2hyunwoo l2hyunwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 코멘트 하나만 확인해주세용

app/src/main/java/com/teampophory/pophory/feature/qr/QRActivity.kt Show resolved Hide resolved
@librarywon librarywon merged commit e1e95b8 into release/1.2.0 Oct 26, 2023
1 check passed
@librarywon librarywon deleted the feature/qr_qa branch October 26, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l2hyunwoo l2hyunwoo l2hyunwoo approved these changes

Assignees

@librarywon librarywon

Labels
🐞 BugFix Something isn't working ✨ Feature 기능 개발 🦈서재원 서재원이 했다
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature/qr_qa] 3차 QA QR관련 대응
2 participants
@librarywon @l2hyunwoo