Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCL improvements #99

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thecraftianman
Copy link

@thecraftianman thecraftianman commented Aug 5, 2024

NOTE: This change also requires the matching ULX pull request to avoid breakage: TeamUlysses/ulx#226

This PR has two main changes that impact UCL:

  • UCL networking updates no longer resend all player and group data at once; instead, only the data for the applicable player/group will be networked to users upon an update
    • To facilitate this, two new clientside functions have been added: ucl.updateClientUCLPlayer( id, data ) and ucl.updateClientUCLGroup( name, data )
  • ucl.authed now uses SteamID64 internally instead of UniqueID
    • All functions that have been impacted by this change now support SteamID64 as a parameter as well, but all of this can be reverted if just using SteamID would be preferred

Tested both in a local server and on a public server for a couple weeks now with no regressions found.

A couple uses of UniqueID in functions have been kept for backwards compatibility, but honestly I'm not sure if those need to remain either
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant