Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Eric Erhardt <[email protected]>
  • Loading branch information
benaadams and eerhardt authored Nov 14, 2022
1 parent ed54185 commit bec2f23
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ public partial class BenchmarkApplication
{
private static ReadOnlySpan<byte> _fortunesPreamble =>
"HTTP/1.1 200 OK\r\n"u8 +
"Server: K"u8 + "\r\n"u8 +
"Content-Type: text/html; charset=UTF-8"u8 + "\r\n"u8 +
"Server: K\r\n"u8 +
"Content-Type: text/html; charset=UTF-8\r\n"u8 +
"Content-Length: "u8;

private async Task Fortunes(PipeWriter pipeWriter)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ public partial class BenchmarkApplication

private static ReadOnlySpan<byte> _jsonPreamble =>
"HTTP/1.1 200 OK\r\n"u8 +
"Server: K"u8 + "\r\n"u8 +
"Content-Type: application/json"u8 + "\r\n"u8 +
"Server: K\r\n"u8 +
"Content-Type: application/json\r\n"u8 +
"Content-Length: 27"u8;

private static void Json(ref BufferWriter<WriterAdapter> writer, IBufferWriter<byte> bodyWriter)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@ namespace PlatformBenchmarks;

public partial class BenchmarkApplication
{
private static ReadOnlySpan<byte> _applicationName => "Kestrel Platform-Level Application"u8;
public static ReadOnlySpan<byte> ApplicationName => _applicationName;
public static ReadOnlySpan<byte> ApplicationName => "Kestrel Platform-Level Application"u8;

private static ReadOnlySpan<byte> _crlf => "\r\n"u8;
private static ReadOnlySpan<byte> _eoh => "\r\n\r\n"u8; // End Of Headers
Expand Down

0 comments on commit bec2f23

Please sign in to comment.