Updated composer.json to CakePHP 2.10.3 #2992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erify --test cakephp
|
Hi @aaron-hall-7 Thanks for your first contribution! It looks like travis didn't like this. I'm rerunning it. You say this passed in your local environment? If you could post a log of that here, that would be great! We'll have to figure out why we can't get a pass on travis before we merge. |
|
@nbrady-techempower I'm now seeing warnings (but no errors) when running the tests locally. I'll clean up these warnings on my end and push the changes again which may hopefully clean up the errors on Travis |
|
@aaron-hall-7 Looks like it passed after the rerun. Feel free to open another PR if you have additional improvements and I'll merge this one now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested running against tfb --mode verify --test cakephp