Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] Postgres 16 Support #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oskardotglobal
Copy link

After the chaos in #17 I decided to just PR this myself.
I'll have to make some changes, but this should be ready to go soon.

@oskardotglobal oskardotglobal changed the title [ADD] [WIP] Postgres 16 Support [ADD] Postgres 16 Support Aug 2, 2024
@oskardotglobal oskardotglobal marked this pull request as ready for review August 2, 2024 12:28
@pleirb
Copy link

pleirb commented Aug 5, 2024

After the chaos in #17 I decided to just PR this myself. I'll have to make some changes, but this should be ready to go soon.

Thank you so much !
Will this soon be available in the doodba-copier-template project as well?

@oskardotglobal
Copy link
Author

Once this is merged that will definitely be possible, but I will not PR those changes myself as I don't use that template.

@bosd
Copy link

bosd commented Aug 5, 2024

@oskardotglobal Can you clean up this pr? Please remove unnessecary commits.
Please keep V14
& squash the commits? 🙏

@josep-tecnativa
Copy link
Contributor

You could base your PR on this 8179fde as it is analogous to what you want to do, but with Postgres 15.

@oskardotglobal
Copy link
Author

@bosd I will squash the commits. I seem to have removed V14 accidentally, I will readd this.

@josep-tecnativa Thank you for the suggestion, but I think moving the build steps to actions from the python scripts is a much cleaner solution. I will still update the tests accordingly.

@josep-tecnativa
Copy link
Contributor

josep-tecnativa commented Oct 4, 2024

Sorry for the delay, but, Could you divide this PR in 2 commits? One fort testing and one for PG16 suport. Once this is made, I think it is ready to merge

@oskardotglobal
Copy link
Author

I don't think I can do that in a simple way; I've rewritten history in my local repo and force-pushed the remote

@pedrobaeza
Copy link
Member

@josep-tecnativa what about this?

@josep-tecnativa
Copy link
Contributor

Since we needed to have PG 16 quickly, I made another PR and merged it. If you can modify this PR or create a new one with changes that are not related to PG 16, I will review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants