Resolve an issue when null is in an array #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KyleAMathews - Any luck on looking at getting this merged in? |
|
@kodypeterson hey! I'd love to make you a collaborator so you can merge this and other PRs and roll a new release! Please signup over at #25 and let's make this happen! |
|
This change makes sense to me. My paranoia kind of wants another test to make sure null values work fine when being merged with non-null values at the same index in the other array, but otherwise this looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I found that the typeof null is an object. So, when null exists in an array it wants to attempt a merge on it. Well, then Object.keys(null) bombs out. This resolves the issue 😄