Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactors for clarity #27

Merged
merged 1 commit into from
Sep 27, 2016
Merged

Small refactors for clarity #27

merged 1 commit into from
Sep 27, 2016

Conversation

TehShrike
Copy link
Owner

  • replacing bool && val || val with the more readable ternary operator
  • turned an else block that contained only an if block into an else if

@TehShrike
Small refactors for clarity
28fae9e 
- replacing bool && val || val with the more readable ternary operator
- turned an else block that contained only an if block into an else if
@TehShrike
Copy link
Owner Author

In the absence of CI testing: I ran the tests and they still pass!

@TehShrike
Copy link
Owner Author

😿

@KyleAMathews
Copy link
Collaborator

@TehShrike hey I'd love to make you a collaborator so you can merge this in and create a new NPM release! Please signup over at #25 and let's make this happen!

@TehShrike TehShrike merged commit 4f57a2d into TehShrike:master Sep 27, 2016
@TehShrike TehShrike deleted the refactoring-for-clarity branch September 27, 2016 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TehShrike @KyleAMathews