Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve options section of the readme #51

Merged
merged 2 commits into from
Dec 3, 2016
Merged

Improve options section of the readme #51

merged 2 commits into from
Dec 3, 2016

Conversation

ArtskydJ
Copy link
Contributor

  • Clarify arrayMerge's arguments.
  • Fix clone heading level.

@TehShrike
Copy link
Owner

Looks good to me. I wonder if those comments inside concatMerge should be assertion comments with the =>, just to guarantee they're correct?

@ArtskydJ
Copy link
Contributor Author

ArtskydJ commented Nov 17, 2016 •
edited
Loading

Like this?

destinationArray // => [1, 2, 3]
sourceArray // => [3, 2, 1]
options // => { arrayMerge: concatMerge }

@TehShrike
Copy link
Owner

Yeah, that should do it I think.

@ArtskydJ
Copy link
Contributor Author

Done.

@TehShrike TehShrike merged commit c8b04a9 into TehShrike:master Dec 3, 2016
@TehShrike
Copy link
Owner

Published as 1.3.1. Thanks!

@ArtskydJ ArtskydJ deleted the patch-1 branch December 5, 2016 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArtskydJ @TehShrike