review feedback #814
Merged
review feedback #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temple v2 review feedback tests
…d Liquidity with latest tokenVault functions
…longer, ramos does it & tests updated
…le into temple-v2-review-feedback-ostrich
Temple V2 review updates
* Update TRV to be multi-asset * Merged from upstream * Update events from RamosStrategy * update tlc interface to remove cooldown (#818) * update tlc interface to remove cooldown * update tlc interface to remove cooldown * update tlc interface to remove cooldown * Temple v2 circuit breaker (#820) * initial circuit breaker algo * fix/optimisation * Add tests, optimise, cleanup - start proxy * Update TLC to remove requests * Added tests, improved gas * Added tests, improved gas * Correct tests * Merged with upstream * Correct tests
* test: add missing ramos strategy test vault functions * test: update TEMPLE_INITIAL_TOTAL_SUPPLY val
protocol/contracts/v2/circuitBreaker/TempleCircuitBreakerAllUsersPerPeriod.sol
Show resolved
Hide resolved
protocol/contracts/v2/circuitBreaker/TempleCircuitBreakerAllUsersPerPeriod.sol
Show resolved
Hide resolved
protocol/contracts/v2/circuitBreaker/TempleCircuitBreakerAllUsersPerPeriod.sol
Show resolved
Hide resolved
protocol/test/forge/v2/circuitBreaker/TempleCircuitBreakerAllUsersPerPeriod.t.sol
Show resolved
Hide resolved
protocol/test/forge/v2/circuitBreaker/TempleCircuitBreakerAllUsersPerPeriod.t.sol
Show resolved
Hide resolved
frontier159
added a commit
that referenced
this pull request
Jul 7, 2023
* fix: addliquidity calculation (#728) (#729) * feat: temple v2 interfaces * feat: dUSD initial implementation. testing wip * feat: cleanup, more tests * feat: cleanup, more tests * feat: dUSD implementation and tests * feat: minor updates, improved tests * slither updates * feat: start of strategies * feat: add dusd testnet admin contract * feat: added DSR base strategy * feat: initial TRV - still WIP * feat: still WIP * feat: strategies report asset balances * feat: strategies report asset balances * feat: tests * feat: gnosis strategy tests * feat: wip dsr base strategy tests * feat: wip continues * Add safe guard * Convert to revert string error for Safe UI * Refactor elevated access * Add v2 readme * Add v2 readme * Updated access * Updated readme, batch update on guard * Update README.md Cleaned up the wording for clarity / readability * TLC pre-requisites (#804) * Updated Temple v2 to support TLC * Add the RAMOS strategy (#805) * implement the RAMOS strategy reporting the underlying assets * add tests for RAMOS strategy * disable the ETH balance report * update tests for RAMOS strategy * add TPI on TRV constructor in RAMOS strategy test * implement functions to add/remove liquidity on RAMOS strategy * proportional add liquidity * update the addLiquidity function on RAMOS and the quote functions on PoolHelper * update RAMOS contract and tests * implement borrow/repay features on RAMOS strategy and add tests for borrow * fix bpt total supply issue and add tests for repay * fix issues on RAMOS contract * remove operators from RAMOS strategy * update tests for adding/removing the liquidity * fix tests for RAMOS and PoolHelper contracts * update the RAMOS access control mechanism and fix the tests for RAMOS and RAMOS strategy * set the explicit access to RAMOS on RAMOS strategy test * Tlc (#806) * Updated Temple v2 to support TLC * Updated Temple v2 to support TLC * Updated Temple v2 to support TLC * Initial TLC * Make TLC a strategy * Use an index accumulator instead of shares * Updates, gas golfing * comment out logs * Tlc reworked (#807) * Reworked to fit size - strategy split out * Tlc delegatecall (#808) * delegatecall * Reworked to fit size - strategy split out * added storage to interfaces * fix up (#809) * update names * remove loops * add expiry to fund request window * refactor to take token address as input * further tests * tests, tests, tests * split fund request types, tests * positive interest rate only * add more tests, cleanup * comment all of the things * a couple of extra tests * remove oud, update tests * flatten TLC contract * fix edge cases on interest rate model * interface tweaks to shutdown, asset balances * PR feedback, solhint * refactor ramos imports, ramos strategy updates * Update ramos tests * Add comments to Ramos, autoshutdown ramos * Move TPI into a separate oracle contract * rename temple/stable in ramos * ramos rebalance up/down join & exit * Add fees to ramos * review feedback (#814) * review feedback --------- Co-authored-by: frost ostrich <[email protected]> Co-authored-by: frost-ostrich <[email protected]> * gh hardhat tests * slither --------- Co-authored-by: Nicho <[email protected]> Co-authored-by: jebsley3 <[email protected]> Co-authored-by: Marshall <[email protected]> Co-authored-by: temple-advocate <[email protected]> Co-authored-by: cool-eth <[email protected]> Co-authored-by: frost ostrich <[email protected]> Co-authored-by: frost-ostrich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does this PR solve?
Fixes # (issue)
Checklist