-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temple v2 post audit #842
Merged
Merged
Temple v2 post audit #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frontier159
force-pushed
the
temple-v2-post-audit
branch
from
August 14, 2023 07:54
6383e73
to
e0464a6
Compare
frontier159
force-pushed
the
temple-v2-post-audit
branch
from
August 14, 2023 22:20
0820dd9
to
1d85034
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments
protocol/test/forge/v2/templeLineOfCredit/TlcLiquidations.t.sol
Outdated
Show resolved
Hide resolved
protocol/test/forge/v2/safeGuards/CompatibilityFallbackHandler.forked.sol
Show resolved
Hide resolved
princetonbishop
approved these changes
Aug 23, 2023
Merged
princetonbishop
pushed a commit
that referenced
this pull request
Sep 18, 2023
* fix: v2 audit: yAudit/temple-lending-report#1 * fix: v2 audit: yAudit/temple-lending-report#2 * fix: v2 audit: yAudit/temple-lending-report#3 * fix: v2 audit: yAudit/temple-lending-report#5 * fix: v2 audit: yAudit/temple-lending-report#6 * fix: v2 audit: yAudit/temple-lending-report#7 * fix: v2 audit: yAudit/temple-lending-report#9 * fix: v2 audit: yAudit/temple-lending-report#10 * fix: v2 audit: yAudit/temple-lending-report#11 * fix: v2 audit: yAudit/temple-lending-report#12 * fix: v2 audit: yAudit/temple-lending-report#14 * fix: v2 audit: yAudit/temple-lending-report#15 * fix: v2 audit: yAudit/temple-lending-report#16 yAudit/temple-lending-report#18 * fix: v2 audit: yAudit/temple-lending-report#17 * fix: v2 audit: yAudit/temple-lending-report#20 * fix: v2 audit: yAudit/temple-lending-report#22 yAudit/temple-lending-report#23 * fix: v2 audit: yAudit/temple-lending-report#24 * fix: v2 audit: yAudit/temple-lending-report#26 * fix: v2 audit: yAudit/temple-lending-report#27 * fix: v2 audit: yAudit/temple-lending-report#28 * fix: v2 audit: yAudit/temple-lending-report#29 * fix: v2 audit: yAudit/temple-lending-report#30 * fix: v2 audit: yAudit/temple-lending-report#31 * fix: v2 audit: yAudit/temple-lending-report#32 * fix: v2 audit: yAudit/temple-lending-report#35 * fix: v2 audit: yAudit/temple-lending-report#36 * fix: v2 audit: yAudit/temple-lending-report#38 * fix: v2 audit: yAudit/temple-lending-report#40 * fix: v2 audit: yAudit/temple-lending-report#41 * fix: v2 audit: yAudit/temple-lending-report#42 * fix: v2 audit: yAudit/temple-lending-report#44 * fix: v2 audit: yAudit/temple-lending-report#45 Also see PaulRBerg/prb-math#198 * fix: v2 audit: yAudit/temple-lending-report#46 * fix: v2 audit: yAudit/temple-lending-report#49 * fix: v2 audit: yAudit/temple-lending-report#48 * fix: v2 audit: yAudit/temple-lending-report#50 * fix: v2 audit: yAudit/temple-lending-report#51 * fix: v2 audit: yAudit/temple-lending-report#52 * fix: v2 audit: yAudit/temple-lending-report#53 * fix: v2 audit: yAudit/temple-lending-report#54 * fix: v2 audit: yAudit/temple-lending-report#55 * fix: v2 audit: yAudit/temple-lending-report#12 part 2 * fix: v2 audit: yAudit/temple-lending-report#5 part 2 * update dToken for gas optimisations and extra events * fix: v2 audit: yAudit/temple-lending-report#56 * fix: v2 audit: yAudit/temple-lending-report#46 (updated to how it was addressed) * added extra test, removed redundant error, partially reverted 6cd79a0 * updated foundry version, slither, CI * corrected safe fork lib to be internal * dtoken rounding * rename postRebalanceSlippage => postRebalanceDelta * updates after internal review * dariox request -- add the DebtCeilingUpdated event on addStrategy * add complex liquidation test when rescue mode/paused liquidations * review feedback on safe guard test * review feedback on temple base strategy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does this PR solve?
Fixes # (issue)
Checklist