Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsc): fix JSCCtxValue crash after destroy engine #3423

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

etkmao
Copy link
Collaborator

@etkmao etkmao commented Aug 2, 2023

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@github-actions github-actions bot added framework: ios driver: js size: xs Denotes a PR that changes 0-9 lines labels Aug 2, 2023
@hippy-service
Copy link

hippy-service bot commented Aug 2, 2023

Hi, @etkmao. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@hippy-service
Copy link

hippy-service bot commented Aug 2, 2023

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Aug 2, 2023
@hippy-actions hippy-actions bot enabled auto-merge (rebase) August 2, 2023 07:46
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Aug 2, 2023
@hippy-actions hippy-actions bot merged commit 06ca1cd into Tencent:main Aug 2, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
driver: js framework: ios size: xs Denotes a PR that changes 0-9 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants