Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): add safe static var for ios static crash #4039

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(core): add safe static var for ios static crash #4039

wants to merge 2 commits into from
+58 −13

Conversation

etkmao
Copy link
Collaborator

@etkmao etkmao commented Sep 18, 2024

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@etkmao etkmao requested a review from wwwcg September 18, 2024 10:09
@github-actions github-actions bot added driver: js dom: tree module: footstone size: s Denotes a PR that changes 10-99 lines labels Sep 18, 2024
@hippy-service Hippy Service
Copy link

hippy-service bot commented Sep 18, 2024

Hi, @etkmao. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilikethese ilikethese Awaiting requested review from ilikethese ilikethese is a code owner

@wwwcg wwwcg Awaiting requested review from wwwcg

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dom: tree driver: js module: footstone size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@etkmao