-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Input): fallback to using tap event #2946
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -6 B (0%) Total Size: 205 kB
ℹ️ View Unchanged
|
Size Change: -6 B (0%) Total Size: 205 kB
ℹ️ View Unchanged
|
@anlyyao 太细致啦! |
jarmywang
approved these changes
Jul 3, 2024
Merged
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是?
🔗 相关 Issue
fix #2937
💡 需求背景和解决方案
背景: wxif + bindtouchstart,点击该事件后dom销毁,当前页面上的其他bindtap事件无效, bindtouchstart事件正常。代码片段:https://developers.weixin.qq.com/s/noGD5mmY76Sc
原因:根本原因是 touchstart 阶段就删除了节点,导致 touchend 没触发
解决方案:两个方向:1.不删除节点(wxif改用hidden);2.改用tap/touchend 删除节点
方案效果对比:ios
历史变更记录:
在 #1702 中,为达到"清空内容时,软键盘不收起"的交互效果,从 tap 改用 touchstart,当前为了保证skyline render环境下的正常使用和交互效果一致,重新改用 tap,webview环境下的交互效果会变更为“清空内容时,软键盘收起”。
📝 更新日志
fix(Input): 修复Skyline下点击清除图标时页面上
bindtap
无效本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单