Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(collapse-panel): expandIcon does not take effect #3093

Merged
merged 2 commits into from
Sep 1, 2024

Conversation

blankqwq
Copy link
Contributor

@blankqwq blankqwq commented Aug 23, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复

🔗 相关 Issue

💡 需求背景和解决方案

image

父级 collapse 默认值为true ,所以只在 collapse-panel 设置 false 无效

📝 更新日志

  • fix(collapse): 修复collapse-panel设置expand-icon不生效及支持动态设置diabled

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@blankqwq
Copy link
Contributor Author

我还想想监听下diabled的变化可以嘛

    this.observers={
            disabled(v){
               v!=null && this.setData({ultimateDisabled: v});
            }
  }

@jarmywang
Copy link
Collaborator

我还想想监听下diabled的变化可以嘛

    this.observers={
            disabled(v){
               v!=null && this.setData({ultimateDisabled: v});
            }
  }

感谢建议,抱歉现在才看,我认为可以加,场景:动态触发disabled。我切你分支补充吧。@blankqwq @anlyyao

@jarmywang jarmywang merged commit cc2c61b into Tencent:develop Sep 1, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants