chore(Textarea): complete refactoring #526
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
anlyyao
force-pushed
the
chore/textarea
branch
from
22da10a
to
e27ab94
Compare
jarmywang
approved these changes
Oct 9, 2024
HaixingOoO
reviewed
Oct 9, 2024
| ...otherProps | ||
| } = props; | ||
|
|
||
| const textareaClass = usePrefixClass('textarea'); | ||
|
|
||
| const [value = '', setValue] = useDefault(props.value, defaultValue, props.onChange); |
HaixingOoO
reviewed
Oct 9, 2024
| const { disabled, maxlength, maxcharacter, autofocus, defaultValue, autosize = false, label, ...otherProps } = props; | ||
| const { classPrefix } = useConfig(); | ||
| const baseClass = `${classPrefix}-textarea`; | ||
| const Textarea = forwardRef((originProps: TextareaProps, ref: TextareaRefInterface) => { |
HaixingOoO
reviewed
Oct 9, 2024
Comment on lines
+125
to
+129
| const handleCompositionEnd = (e) => { | ||
| if (composingRef.current) { | ||
| composingRef.current = false; | ||
| inputValueChangeHandle(e); | ||
| } |
There was a problem hiding this comment.
火狐瀏覽器的執行順序和chrome不同，所以firefox的inputValueChangeHandle會執行兩次
HaixingOoO
reviewed
Oct 9, 2024
| @@ -84,27 +138,40 @@ const Textarea = forwardRef((props: TextareaProps, ref: TextareaRefInterface) => | |||
| textareaElement: textareaRef.current, | |||
| })); | |||
|
|
|||
| const renderLabel = () => label && <div className={`${textareaClass}__label`}> {parseTNode(label)} </div>; | |||
There was a problem hiding this comment.
感覺label可以提到外面判斷，可以減少每次都執行函數
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
相关PR
TDesignOteam/tdesign-api#432
Tencent/tdesign-common#1943
💡 需求背景和解决方案
📝 更新日志
breaking(Textarea): 组件重构，新增
allowInputOverMax，bordered与readonly等属性本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单