-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Textarea): complete refactoring #526
base: develop
Are you sure you want to change the base?
Conversation
22da10a
to
e27ab94
Compare
...otherProps | ||
} = props; | ||
|
||
const textareaClass = usePrefixClass('textarea'); | ||
|
||
const [value = '', setValue] = useDefault(props.value, defaultValue, props.onChange); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
value=''可以刪掉=''
const { disabled, maxlength, maxcharacter, autofocus, defaultValue, autosize = false, label, ...otherProps } = props; | ||
const { classPrefix } = useConfig(); | ||
const baseClass = `${classPrefix}-textarea`; | ||
const Textarea = forwardRef((originProps: TextareaProps, ref: TextareaRefInterface) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
類型可寫在forwardRef裡
const handleCompositionEnd = (e) => { | ||
if (composingRef.current) { | ||
composingRef.current = false; | ||
inputValueChangeHandle(e); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
火狐瀏覽器的執行順序和chrome不同,所以firefox的inputValueChangeHandle會執行兩次
@@ -84,27 +138,40 @@ const Textarea = forwardRef((props: TextareaProps, ref: TextareaRefInterface) => | |||
textareaElement: textareaRef.current, | |||
})); | |||
|
|||
const renderLabel = () => label && <div className={`${textareaClass}__label`}> {parseTNode(label)} </div>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感覺label可以提到外面判斷,可以減少每次都執行函數
🤔 这个 PR 的性质是?
🔗 相关 Issue
相关PR
TDesignOteam/tdesign-api#432
Tencent/tdesign-common#1943
💡 需求背景和解决方案
📝 更新日志
breaking(Textarea): 组件重构,新增
allowInputOverMax
,bordered
与readonly
等属性本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单