Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ConfigProvider): 全局配置 #1240

Merged
merged 7 commits into from
Feb 28, 2024
Merged

feat(ConfigProvider): 全局配置 #1240

merged 7 commits into from
Feb 28, 2024

Conversation

anlyyao
Copy link
Collaborator

@anlyyao anlyyao commented Feb 28, 2024

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

说明：仅针对组件内置“文本”进行多语言支持，目前语言包有：中文（简体）、英文，后续会持续支持全局配置组件类名前缀、支持配置按钮，其TS类型扩展ButtonProps，当前仅支持String。

📝 更新日志

  • feat(ConfigProvider): 全局配置组件，支持组件国际化

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 28, 2024 •
edited
Loading

完成

@github-actions GitHub Actions
Copy link
Contributor

Size Change: +5.92 kB (+1%)

Total Size: 427 kB

Filename Size Change
./dist/tdesign.js 227 kB +4.08 kB (+2%)
./dist/tdesign.min.js 134 kB +1.84 kB (+1%)
ℹ️ View Unchanged
Filename Size
./dist/reset.css 672 B
./dist/tdesign.css 37.8 kB
./dist/tdesign.min.css 27.5 kB

@github-actions GitHub Actions
Copy link
Contributor

Size Change: +5.91 kB (+1%)

Total Size: 427 kB

Filename Size Change
./dist/tdesign.js 227 kB +4.08 kB (+2%)
./dist/tdesign.min.js 134 kB +1.83 kB (+1%)
ℹ️ View Unchanged
Filename Size
./dist/reset.css 672 B
./dist/tdesign.css 37.8 kB
./dist/tdesign.min.css 27.5 kB

anlyyao
anlyyao commented Feb 28, 2024
View reviewed changes
src/calendar/template.vue Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Size Change: +5.91 kB (+1%)

Total Size: 427 kB

Filename Size Change
./dist/tdesign.js 227 kB +4.08 kB (+2%)
./dist/tdesign.min.js 134 kB +1.83 kB (+1%)
ℹ️ View Unchanged
Filename Size
./dist/reset.css 672 B
./dist/tdesign.css 37.8 kB
./dist/tdesign.min.css 27.5 kB

jarmywang
jarmywang reviewed Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@jarmywang jarmywang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看下date-picker这里，英语语境一般月在年前面

@anlyyao
Copy link
Collaborator Author

anlyyao commented Feb 28, 2024

看下date-picker这里，英语语境一般月在年前面

@uyarn 看一下这个问题

@anlyyao
Copy link
Collaborator Author

anlyyao commented Feb 28, 2024

看下date-picker这里，英语语境一般月在年前面

@uyarn 看一下这个问题

补充一下结论： February 2024

@github-actions GitHub Actions
Copy link
Contributor

Size Change: +6 kB (+1%)

Total Size: 427 kB

Filename Size Change
./dist/tdesign.js 227 kB +4.13 kB (+2%)
./dist/tdesign.min.js 134 kB +1.87 kB (+1%)
ℹ️ View Unchanged
Filename Size
./dist/reset.css 672 B
./dist/tdesign.css 37.8 kB
./dist/tdesign.min.css 27.5 kB

@github-actions GitHub Actions
Copy link
Contributor

Size Change: +6 kB (+1%)

Total Size: 427 kB

Filename Size Change
./dist/tdesign.js 227 kB +4.13 kB (+2%)
./dist/tdesign.min.js 134 kB +1.87 kB (+1%)
ℹ️ View Unchanged
Filename Size
./dist/reset.css 672 B
./dist/tdesign.css 37.8 kB
./dist/tdesign.min.css 27.5 kB

@anlyyao anlyyao merged commit 057d0ba into develop Feb 28, 2024
8 checks passed
@anlyyao anlyyao deleted the feat/config-provider branch February 28, 2024 09:32
@github-actions github-actions bot mentioned this pull request Feb 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarmywang jarmywang jarmywang left review comments

@yaogengzhu yaogengzhu yaogengzhu approved these changes

@uyarn uyarn uyarn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anlyyao @jarmywang @uyarn @yaogengzhu