Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(Popup): remove bodyLockClass after the component instance is unmounted #1504

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

QuentinHsu
Copy link
Contributor

@QuentinHsu QuentinHsu commented Jul 17, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

fix #1503

💡 需求背景和解决方案

📝 更新日志

perf(Popup): remove bodyLockClass after the component instance is unmounted

  • fix(Popup): 处理窗体类组件隐藏时 t-popup-overflow-hidden 等类名未移除的问题
  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented Jul 17, 2024

完成

@QuentinHsu
Copy link
Contributor Author

我又想了下,该样式 bodyLockClass 所带来的影响为副作用,应该在组件实例被卸载之后去清除副作用。
我将改为 unmounted 时去清除。

@QuentinHsu QuentinHsu changed the title perf(Popup): remove bodyLockClass before the component instance is unmounted perf(Popup): remove bodyLockClass after the component instance is unmounted Jul 17, 2024
@anlyyao anlyyao merged commit 52f89f9 into Tencent:develop Jul 23, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Jul 23, 2024
@QuentinHsu QuentinHsu deleted the fix-popup-body-lock-class branch July 25, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ActionSheet] 通过函数方式打开并关闭该组件后,popup 的 bodyLockClass 未移除
2 participants