fix(skeleton): 修复skeleton响应性问题 #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
https://github.com/Tencent/tdesign-mobile-vue/blob/develop/package.json#L87 |
|
你本地重新安装一下依赖，然后更新 snapshot 应该就能看到有修改了，重新提交上来 |
|
action跑测试用例有点问题，执行一下npm run test:update，把新生成的snap文件提交上来试试 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #235
🤔 这个 PR 的性质是？
🔗 相关 Issue
#235
💡 需求背景和解决方案
skeleton组件中传的props值仅第一次赋值可用，后续改变props值时骨架屏不会及时响应，主要的问题在于vue3中需要使用toRefs使得props中的参数获得响应性，直接获取props的值仅为固定的值
📝 更新日志
fix(Skeleton): 修复 props 变化不重新渲染的问题
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单