Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/link #589

Merged
merged 14 commits into from
Apr 17, 2023
Merged

Refactor/link #589

merged 14 commits into from
Apr 17, 2023

Conversation

brianzhang
Copy link
Contributor

@brianzhang brianzhang commented Apr 14, 2023

🤔 这个 PR 的性质是?

  • [ Link] 新特性提交

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • feat(Link): 新增 Link 组件

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2023

完成

@LeeJim LeeJim added the in progress 正在处理中 label Apr 15, 2023
@anlyyao
Copy link
Collaborator

anlyyao commented Apr 17, 2023

问题:1. 前置图标和后置图标示例位置错误
企业微信截图_7720df2d-221c-442d-9444-eb75d836ad06
2. prefix 前面不需要边距
截屏2023-04-17 11 02 26
3. content 和图标没有垂直居中
截屏2023-04-17 11 02 59

  1. size="medium"时,图标尺寸不对,应该是16px
  2. 下划线可参考以下实现

截屏2023-04-17 11 14 31

@anlyyao anlyyao self-assigned this Apr 17, 2023
src/link/demos/base.vue Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
@anlyyao anlyyao merged commit f584f12 into Tencent:develop Apr 17, 2023
@github-actions github-actions bot mentioned this pull request Apr 17, 2023
LeeJim added a commit that referenced this pull request Apr 18, 2023
* fix: resolve path reference problem (#578)

* refactor(Cascader): new cascader (#533)

* refactor(Cascader): new cascader

* test: update snapshot

---------

Co-authored-by: leejimqiu <[email protected]>

* refactor(badge): new badge (#576)

* refactor(badge): new badge

* refactor(badge): demo base dot

* refactor(badge): demo finish(#576)

* refactor(badge): finish(#576)

* Feat/new grid (#584)

* chore(grid): update demo

* feat(grid): finish new version

* test: update snapshot

* test: update snapshot

* chore: update common

* fix: remove click event

* fix: rename badgeProps

* fix: update demo

* fix(upload): using new style (#587)

* fix(upload): using new style

* fix(upload): finish new upload

* fix(upload): resolve type

* refactor(message): new message (#586)

re #548

* Refactor/link (#589)

* feat: update api

* feat(link mobile component\): link Mobile Component

* feat(create link): create link

* fix(link style fix): link style fix

* feat(merge code): merge code

* fix(update _common): update common

* feat(merge code): merge code

* feat(merge code): merge code

* feat(update snapshots): update snapshots

* feat: 更新link hover,click

* feat(update link demo): update link demo

* feat(create link): create link

* feat(create link): create link

---------

Co-authored-by: anlyyao <[email protected]>

* feat: add form (#591)

* feat: add form

* fix(Form): fix demo

* fix: fix cr

* chore: update common

* chore: publish v0.18.0 (#599)

* chore: publish v0.18.0

* chore: changelog's changes

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: Y <[email protected]>
Co-authored-by: jarmywang <[email protected]>
Co-authored-by: yusuf <[email protected]>
Co-authored-by: brian <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@anlyyao anlyyao mentioned this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress 正在处理中
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants