Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Radio] support keyboard events; support radio.group allowUncheck; add more unit test #1865

Merged
merged 4 commits into from
Jan 6, 2023
Merged

[Radio] support keyboard events; support radio.group allowUncheck; add more unit test #1865

merged 4 commits into from
Jan 6, 2023

Conversation

chaishi
Copy link
Collaborator

@chaishi chaishi commented Jan 6, 2023

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(Radio): 修复 Radio.Group 不支持 name 属性问题

  • feat(Radio): 新增键盘事件支持，tab 键切换选项，enter 键选中

  • feat(Radio): Radio.Group 新增 allowUncheck，支持取消选中（Radio. allowUncheck 本身已支持）

  • feat(Radio): onClick 参数由 (e: MouseEvent) 调整为 ({ e: MouseEvent })

  • test(Radio): 输出完整的测试用例

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023 •
edited
Loading

完成

@chaishi chaishi mentioned this pull request Jan 6, 2023
Open
61 tasks
@honkinglin honkinglin merged commit f99c490 into Tencent:develop Jan 6, 2023
@github-actions github-actions bot mentioned this pull request Jan 11, 2023
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honkinglin honkinglin honkinglin approved these changes

@uyarn uyarn Awaiting requested review from uyarn uyarn is a code owner

@carolin913 carolin913 Awaiting requested review from carolin913 carolin913 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chaishi @honkinglin