skeleton组件问题修复&测试用例完善 #1951
Merged
skeleton组件问题修复&测试用例完善 #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix delay and loading props and test
lihuanIT
requested review from
honkinglin,
uyarn and
carolin913
as code owners
chaishi
reviewed
Feb 7, 2023
| > | ||
| <div | ||
| class="t-skeleton__col t-skeleton--type-text t-skeleton--animation-none" | ||
| /> |
| expect(container.querySelector('.t-skeleton__row')).toBeFalsy(); | ||
| await mockDelay(1000); | ||
| expect(container.querySelector('.t-skeleton__row')).toBeTruthy(); | ||
| it('props.delay: show loading delay 10ms', async () => { |
genyuMPj
reviewed
Feb 8, 2023
| // 骨架屏无需展示 | ||
| if (!loading) { | ||
| // 加载时长超过delay时，需加载DEFAULT_DURATION时长的骨架屏 | ||
| if (delay > 0 && loadingTime.current > delay) { |
There was a problem hiding this comment.
这里当loading 变为false 的时候，是否触发 DEFAULT_DURATION 防闪烁效果，需要判断delay > 0 吗？是不是需要包含delay === 0 的情况呢？ 按照目前的逻辑，会存在比如： 用户设置了delay 默认为0 ，期望出现骨架屏过渡，而加载时间可能是100ms ，也可能是10ms，10ms 的时候还是会出现闪烁现象的~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
📝 更新日志
☑️ 请求合并前的自查清单