Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 文件存储支持主从模式,保证读高可用--task=75127660 #3481

Merged
merged 10 commits into from
Oct 14, 2024

Conversation

fireyun
Copy link
Contributor

@fireyun fireyun commented Aug 31, 2024

No description provided.

@AlkaidChan AlkaidChan added the bcs-bscp feature or bugfix for bscp label Sep 9, 2024
Comment on lines +90 to +94
// SyncManager implements HAEnhancer interface
func (c *bkrepoClient) SyncManager() *SyncManager {
return nil
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里实现为什么是返回空呢

Comment on lines +47 to +50
// SyncManager implements HAEnhancer interface
func (c *cosClient) SyncManager() *SyncManager {
return nil
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cos 和 repo 的这两个实现都是 return nil,是不是可以直接去掉

@AlkaidChan AlkaidChan merged commit 130e784 into TencentBlueKing:master Oct 14, 2024
13 of 14 checks passed
evanlixin added a commit that referenced this pull request Oct 17, 2024
* github-bk-bcs/master:
  fix: 二进制文件添加文件属性对比 (#3573)
  fix: 配置示例windows路径允许使用根目录--bug=132196925 (#3571)
  feat: 新增配置项数量限制提示 (#3570)
  feat: common 添加 redis sdk 支持哨兵和集群模式 (#3546)
  feat: 配置示例:1.根据输入路径自动判断是否为windows路径改为 增加系统单选框,根据单选框判断是否为windows路径;相关逻辑调整;2.键值型命令行工具增加windows相关功能--story=119618143 (#3569)
  feat: 文件存储支持主从模式,保证读高可用--task=75127660 (#3481)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved bcs-bscp feature or bugfix for bscp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants