-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 文件存储支持主从模式,保证读高可用--task=75127660 #3481
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlkaidChan
approved these changes
Oct 8, 2024
Comment on lines
+90
to
+94
// SyncManager implements HAEnhancer interface | ||
func (c *bkrepoClient) SyncManager() *SyncManager { | ||
return nil | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里实现为什么是返回空呢
Comment on lines
+47
to
+50
// SyncManager implements HAEnhancer interface | ||
func (c *cosClient) SyncManager() *SyncManager { | ||
return nil | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cos 和 repo 的这两个实现都是 return nil,是不是可以直接去掉
evanlixin
added a commit
that referenced
this pull request
Oct 17, 2024
* github-bk-bcs/master: fix: 二进制文件添加文件属性对比 (#3573) fix: 配置示例windows路径允许使用根目录--bug=132196925 (#3571) feat: 新增配置项数量限制提示 (#3570) feat: common 添加 redis sdk 支持哨兵和集群模式 (#3546) feat: 配置示例:1.根据输入路径自动判断是否为windows路径改为 增加系统单选框,根据单选框判断是否为windows路径;相关逻辑调整;2.键值型命令行工具增加windows相关功能--story=119618143 (#3569) feat: 文件存储支持主从模式,保证读高可用--task=75127660 (#3481)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.