feat： json文件生成的流水线自动下载范围可见插件 #5939 #6410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlyin0801
reviewed
Mar 25, 2022
.../biz-process/src/main/kotlin/com/tencent/devops/process/service/PipelineInfoFacadeService.kt
Show resolved
Hide resolved
carlyin0801
reviewed
Mar 30, 2022
| ) | ||
| if (validateRet.isNotOk()) { | ||
| throw OperationException(validateRet.message ?: "模版下存在无权限的组件") | ||
| } |
There was a problem hiding this comment.
用ErrorCodeException封装异常，需要有明确的错误码
| userId: String, | ||
| model: Model, | ||
| projectCodeList: ArrayList<String>, | ||
| templateCode: String? |
There was a problem hiding this comment.
templateCode定义成为默认可为空吧，这样调这个方法的时候就可以不传参了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat： json文件生成的流水线自动下载范围可见插件 #5939