pref:worker模块下载接口读取文件流出错应该整个接口重试 #6404 #6422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlyin0801
reviewed
Mar 25, 2022
| writeTimeoutInSec = writeTimeoutInSec | ||
| ).use { response -> | ||
| retryCount = download(response, destPath, retryCount) | ||
| } |
There was a problem hiding this comment.
这么写不符合面向对象思想，这代码看起来了是必须要重试，不能在捕获异常的时候直接调最外层的downloa方法重试下载接口吗
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pref:worker模块下载接口读取文件流出错应该整个接口重试 #6404