Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 流水线支持设置并发组执行策略 #6521 #6540

Merged
merged 6 commits into from
Apr 18, 2022
Merged

feat: 流水线支持设置并发组执行策略 #6521 #6540

merged 6 commits into from
Apr 18, 2022

Conversation

yongyiduan
Copy link
Collaborator

@yongyiduan yongyiduan commented Apr 15, 2022 •
edited by royalhuang
Loading

流水线支持设置并发组执行策略 #6521

irwinsun
irwinsun reviewed Apr 17, 2022
View reviewed changes
Copy link
Member

@irwinsun irwinsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2点：
1、SQL DDL 补充
2、 QueueIntercepter.cancelBuildPipeline与PipelineRuntimeExtService.popAllConcurrencyGroupBuildInfo 是否存在不必要的操作

irwinsun
irwinsun requested changes Apr 17, 2022
View reviewed changes
Copy link
Member

@irwinsun irwinsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注意BuildInfo 存在Json对象
从目前来看 pipelineRuntimeService.getBuildInfoListByConcurrencyGroup 返回了过多的内容
建议重新修改函数名称，并DAO层只查取返回需要的字段，
目前用途仅用于读取pipelineId, buildId, 以及 count计数，不需要将整个记录字段都返回

@irwinsun irwinsun merged commit 2fb6bed into TencentBlueKing:master Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royalhuang royalhuang royalhuang approved these changes

@irwinsun irwinsun irwinsun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yongyiduan @irwinsun @royalhuang