Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.6 #17

Merged
merged 4 commits into from
Mar 31, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.0.5
1.0.6
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ index:
elasticsearch:
indexName: iam_policy
addresses:
- http://__BK_IAM_SEARCH_ENGINE_ES_HOST__:__BK_IAM_SEARCH_ENGINE_ES_PORT__
username: "__BK_IAM_SEARCH_ENGINE_ES_USER__"
password: "__BK_IAM_SEARCH_ENGINE_ES_PASSWORD__"
- http://__BK_IAM_SEARCH_ENGINE_ES7_HOST__:__BK_IAM_SEARCH_ENGINE_ES7_PORT__
username: "__BK_IAM_SEARCH_ENGINE_ES7_USER__"
password: "__BK_IAM_SEARCH_ENGINE_ES7_PASSWORD__"
maxRetries: 3

backend:
Expand Down
9 changes: 6 additions & 3 deletions pkg/client/es.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*
/*
* TencentBlueKing is pleased to support the open source community by making 蓝鲸智云-权限中心检索引擎
* (BlueKing-IAM-Search-Engine) available.
* Copyright (C) 2017-2021 THL A29 Limited, a Tencent company. All rights reserved.
Expand All @@ -19,6 +19,7 @@ import (
"net/http"
"runtime"
"strconv"
"strings"
"time"

"github.com/cenkalti/backoff/v4"
Expand Down Expand Up @@ -480,8 +481,10 @@ func (c *EsClient) Ping() (*esapi.Response, error) {
}

// CreateIndex ...
func (c *EsClient) CreateIndex(index string) (*esapi.Response, error) {
return c.client.Indices.Create(index)
func (c *EsClient) CreateIndex(index string, mapping string) (*esapi.Response, error) {
return c.client.Indices.Create(index, func(req *esapi.IndicesCreateRequest) {
req.Body = strings.NewReader(mapping)
})
}

// IndexExists ...
Expand Down
6 changes: 3 additions & 3 deletions pkg/engine/doc/es.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*
/*
* TencentBlueKing is pleased to support the open source community by making 蓝鲸智云-权限中心检索引擎
* (BlueKing-IAM-Search-Engine) available.
* Copyright (C) 2017-2021 THL A29 Limited, a Tencent company. All rights reserved.
Expand Down Expand Up @@ -175,8 +175,8 @@ func (e *EsEngine) getActionCount(system, action string) (int, error) {
"query": types.H{
"bool": types.H{
"filter": []interface{}{
types.H{"term": types.H{"system.keyword": system}},
types.H{"term": types.H{"action.id.keyword": action}},
types.H{"term": types.H{"system": system}},
types.H{"term": types.H{"action.id": action}},
},
},
},
Expand Down
29 changes: 12 additions & 17 deletions pkg/engine/doc/es_engine.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*
/*
* TencentBlueKing is pleased to support the open source community by making 蓝鲸智云-权限中心检索引擎
* (BlueKing-IAM-Search-Engine) available.
* Copyright (C) 2017-2021 THL A29 Limited, a Tencent company. All rights reserved.
Expand Down Expand Up @@ -32,7 +32,7 @@ func genDocQuery(req *types.SearchRequest) types.H {
// if x._bk_iam_path_ starts_with /biz,1/cluster,2/ => x._bk_iam_path_ in [/biz,1/, /biz,1/cluster,2/]
if key == types.BkIAMPathKey {
paths := generateBkIAMPathList(value)
term := fmt.Sprintf("resource.%s.%s.%s.keyword", system, resourceNode.Type, key)
term := fmt.Sprintf("resource.%s.%s.%s", system, resourceNode.Type, key)
for _, path := range paths {
sqs = append(sqs, types.H{
"term": types.H{term: path},
Expand All @@ -41,12 +41,7 @@ func genDocQuery(req *types.SearchRequest) types.H {
continue
}

// 除了bk iam path以外的属性不能确定value类型, 判断是string再加上 keyword
fieldName := fmt.Sprintf("resource.%s.%s.%s", system, resourceNode.Type, key)
_, ok := value.(string)
if ok {
fieldName = fieldName + ".keyword"
}
sqs = append(sqs, types.H{
"term": types.H{fieldName: value},
})
Expand Down Expand Up @@ -77,15 +72,15 @@ func genDocQuery(req *types.SearchRequest) types.H {
},
},
},
types.H{"term": types.H{"system.keyword": system}},
types.H{"term": types.H{"action.id.keyword": action}},
types.H{"term": types.H{"type.keyword": string(types.Doc)}},
types.H{"term": types.H{"system": system}},
types.H{"term": types.H{"action.id": action}},
types.H{"term": types.H{"type": string(types.Doc)}},
}

// filter the subject not the req.SubjectType
if req.SubjectType != types.SubjectTypeAll {
must = append(must, types.H{
"term": types.H{"subject.type.keyword": req.SubjectType},
"term": types.H{"subject.type": req.SubjectType},
})
}

Expand Down Expand Up @@ -154,8 +149,8 @@ func genSubjectsBoolCondition(subjects []types.Subject) types.H {
sq := types.H{
"bool": types.H{
"must": []interface{}{
types.H{"term": types.H{"subject.type.keyword": subject.Type}},
types.H{"term": types.H{"subject.id.keyword": subject.ID}},
types.H{"term": types.H{"subject.type": subject.Type}},
types.H{"term": types.H{"subject.id": subject.ID}},
},
},
}
Expand Down Expand Up @@ -189,15 +184,15 @@ func genAnyQuery(req *types.SearchRequest) types.H {
},
},
},
types.H{"term": types.H{"system.keyword": system}},
types.H{"term": types.H{"action.id.keyword": action}},
types.H{"term": types.H{"type.keyword": string(types.Any)}},
types.H{"term": types.H{"system": system}},
types.H{"term": types.H{"action.id": action}},
types.H{"term": types.H{"type": string(types.Any)}},
}

// filter the subject not the req.SubjectType
if req.SubjectType != types.SubjectTypeAll {
filter = append(filter, types.H{
"term": types.H{"subject.type.keyword": req.SubjectType},
"term": types.H{"subject.type": req.SubjectType},
})
}

Expand Down
19 changes: 17 additions & 2 deletions pkg/indexer/index.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*
/*
* TencentBlueKing is pleased to support the open source community by making 蓝鲸智云-权限中心检索引擎
* (BlueKing-IAM-Search-Engine) available.
* Copyright (C) 2017-2021 THL A29 Limited, a Tencent company. All rights reserved.
Expand Down Expand Up @@ -288,7 +288,22 @@ func creatIndexIfNotExists(cfg *config.Index) error {
}

if resp.StatusCode == http.StatusNotFound {
_, err = esClient.CreateIndex(cfg.ElasticSearch.IndexName)
// 动态mapping, match string 类型时索引转换为 keyword 类型
mapping := `{
"mappings": {
"dynamic_templates": [
{
"strings": {
"match_mapping_type": "string",
"mapping": {
"type": "keyword"
}
}
}
]
}
}`
_, err = esClient.CreateIndex(cfg.ElasticSearch.IndexName, mapping)
if err != nil {
return fmt.Errorf("create index: [%s] error:%w", cfg.ElasticSearch.IndexName, err)
}
Expand Down
4 changes: 4 additions & 0 deletions release.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# 1.0.6

- bugfix: create index use dynamic_templates

# 1.0.5

- update: change metrics name with prefix bkiam_search_engine_
Expand Down