Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 作业模板-调试-去执行的申请权限跳转页Bad Request #2359

Closed
wangyu096 opened this issue Aug 22, 2023 · 1 comment
Closed

fix: 作业模板-调试-去执行的申请权限跳转页Bad Request #2359

wangyu096 opened this issue Aug 22, 2023 · 1 comment
Assignees
@wangyu096
Labels
done 已上线到正式环境并验收通过 kind/bug 程序故障Bug，漏洞 tested 已经在测试环境测试通过

Comments

@wangyu096
Copy link
Collaborator

Version / Branch / tag
3.7.x

出了什么问题？(What Happened?)
作业模板-调试-去执行的申请权限跳转页Bad Request

如何复现？(How to reproduce?)

  1. 用户没有编辑执行方案的权限
  2. 点击模版调试，没有权限。点击去申请，页面返回 400 错误
image image

预期结果(What you expect?)
@wangyu096 wangyu096 added kind/bug 程序故障Bug，漏洞 backlog 需求初始状态，等待产品进行评估 labels Aug 22, 2023
@wangyu096 wangyu096 self-assigned this Aug 22, 2023
@wangyu096
Copy link
Collaborator Author

wangyu096 commented Aug 22, 2023 •
edited
Loading

定位

  • 后台报错
image
  • 分析
  1. 调试作业模版，会通过前端调用后端的更新作业执行方案（特殊执行方案，每个作业模版对应一个用于调试的执行方案实例）。这个执行方案对外部系统是不可见的。
  2. 当用户无权限， Job调用权限中心的生成权限申请 URL的 API， 权限中心回调 Job 获取资源详情的时候，Job 并没有返回该资源的信息，导致生成的无权限申请 URL为空
  3. 无权限跳转 URL 错误/debug_plan/null

解决方案

  1. 调试模版保存用于调试的执行方案信息使用 编辑模版 权限鉴权

wangyu096 added a commit to wangyu096/bk-job that referenced this issue Aug 22, 2023
@wangyu096
fix: 作业模板-调试-去执行的申请权限跳转页Bad Request TencentBlueKing#2359
efecb90
@wangyu096 wangyu096 mentioned this issue Aug 22, 2023
Merged
jsonwan added a commit that referenced this issue Aug 22, 2023
@jsonwan
Merge pull request #2362 from wangyu096/issue_2359
6b9af3f 
fix: 作业模板-调试-去执行的申请权限跳转页Bad Request #2359
@bkjob-bot bkjob-bot added for test 可以在测试环境进行验收 for gray 可以在灰度环境/预发布环境验收 and removed backlog 需求初始状态，等待产品进行评估 for test 可以在测试环境进行验收 labels Aug 23, 2023
wangyu096 added a commit to wangyu096/bk-job that referenced this issue Aug 28, 2023
@wangyu096
fix: 作业模板-调试-去执行的申请权限跳转页Bad Request TencentBlueKing#2359
cbe641d
wangyu096 added a commit that referenced this issue Aug 28, 2023
@wangyu096
Merge pull request #2387 from wangyu096/issue_2359_3.7.x
20a6f0f 
fix: 作业模板-调试-去执行的申请权限跳转页Bad Request #2359
@bkjob-bot bkjob-bot added the for test 可以在测试环境进行验收 label Aug 28, 2023
@fabio-he fabio-he added the tested 已经在测试环境测试通过 label Aug 29, 2023
@bkjob-bot bkjob-bot added done 已上线到正式环境并验收通过 and removed for test 可以在测试环境进行验收 tested 已经在测试环境测试通过 for gray 可以在灰度环境/预发布环境验收 labels Aug 29, 2023
@jsonwan jsonwan added the tested 已经在测试环境测试通过 label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wangyu096 wangyu096

Labels
done 已上线到正式环境并验收通过 kind/bug 程序故障Bug，漏洞 tested 已经在测试环境测试通过
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wangyu096 @jsonwan @fabio-he @bkjob-bot