Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: 增加快速执行、执行引擎、定时任务等SLI指标实现 #1101 #1147

Merged
merged 3 commits into from
Jul 27, 2022
Merged

perf: 增加快速执行、执行引擎、定时任务等SLI指标实现 #1101 #1147

merged 3 commits into from
Jul 27, 2022

Conversation

jsonwan
Copy link
Collaborator

@jsonwan jsonwan commented Jul 27, 2022

  1. 处理消息通知接口返回值可能出现的多种数据类型；
  2. 重构部分代码。

@jsonwan
perf: 增加快速执行、执行引擎、定时任务等SLI指标实现 TencentBlueKing#1101
d5c0f9f 
处理消息通知接口返回值可能出现的多种数据类型
wangyu096
wangyu096 requested changes Jul 27, 2022
View reviewed changes
src/backend/commons/esb-sdk/src/test/java/com/tencent/bk/job/common/esb/EsbRespTest.java Outdated
new TypeReference<EsbResp<Object>>() {
}
);
System.out.println("esbResp=" + esbResp);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这句要删除

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已删除

src/backend/commons/esb-sdk/src/test/java/com/tencent/bk/job/common/esb/EsbRespTest.java Outdated
new TypeReference<EsbResp<Object>>() {
}
);
System.out.println("esbResp=" + esbResp);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码中不要出现println

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已删除

@jsonwan jsonwan merged commit 6deb730 into TencentBlueKing:master Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangyu096 wangyu096 wangyu096 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsonwan @wangyu096