bugfix: 全局设置消息预览在发送失败的情况下仍提示发送成功 #1225 #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangyu096
requested changes
Sep 7, 2022
| } catch (Exception e) { | ||
| log.error("Fail to request {}", uri, e); | ||
| status = EsbMetricTags.VALUE_STATUS_ERROR; | ||
| return false; | ||
| throw new PaasException(e, ErrorType.FAILED_PRECONDITION, ErrorCode.CMSI_API_ACCESS_ERROR, new Object[]{}); |
There was a problem hiding this comment.
这个接口调用失败似乎应该是INTERNAL_ERROR,而不是FAILED_PRECONDITION
| "receivers is empty of channel {}, do not send notification", | ||
| channel | ||
| ); | ||
| log.warn(msg.getMessage()); |
There was a problem hiding this comment.
直接log.warn("receivers is empty of channel {}, do not send notification", channel)更加简洁
| ); | ||
| result = true; | ||
| } catch (Exception e) { | ||
| log.warn("Fail to sendMsg", e); |
There was a problem hiding this comment.
这里的异常用ERROR应该会更加合理；warn 一般表示可以被忽略的错误，但是这里如果出错的话，还是需要平台管理员介入的
wangyu096
requested changes
Sep 7, 2022
| } catch (Exception e) { | ||
| log.error("Fail to request {}", uri, e); | ||
| status = EsbMetricTags.VALUE_STATUS_ERROR; | ||
| return false; | ||
| throw new PaasException(e, ErrorType.FAILED_PRECONDITION, ErrorCode.CMSI_API_ACCESS_ERROR, new Object[]{}); |
|
ok |
wangyu096
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
消息发送预览时改用同步发送，以便及时测试通知渠道是否通畅。