perf: 执行引擎部分代码优化 #1616 #1627
Merged
perf: 执行引擎部分代码优化 #1616 #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jsonwan
commented
Dec 15, 2022
jsonwan
commented
- 第三方源文件准备代码添加部分注释、删除无用代码；
- 支持按照任务实例ID进行任务驱逐；
- 修复发现的逻辑bug；
- 任务驱逐部分增加注释、重构部分代码。
第三方源文件准备代码添加部分注释、删除无用代码
支持按照任务实例ID进行任务驱逐； 修复发现的逻辑bug； 增加注释、重构部分代码。
wangyu096
requested changes
Dec 15, 2022
| if (RunStatusEnum.isFinishedStatus(stepInstance.getStatus())) { | ||
| long totalTime = TaskCostCalculator.calculate(stepInstance.getStartTime(), endTime, | ||
| stepInstance.getTotalTime()); | ||
| if (!RunStatusEnum.isFinishedStatus(stepInstance.getStatus())) { |
There was a problem hiding this comment.
这里不是应该等步骤状态被设置为FIINSH STATE ， 才进行后续的任务状态更新么？为啥这次改动中把条件反过来呀?
There was a problem hiding this comment.
这里是驱逐任务后更新任务状态的场景，本来就是要将运行中的状态改为已丢弃状态，应该是之前的代码重构把这里重构错了，这次改了回来。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.