Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fast_transfer_file API 分发文件，如果源文件中的文件名包含空格，会报错 #812 #2041

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: fast_transfer_file API 分发文件，如果源文件中的文件名包含空格，会报错 #812 #2041

wants to merge 4 commits into from

Conversation

liuliaozhong
Copy link
Collaborator

No description provided.

wangyu096
wangyu096 requested changes May 12, 2023
View reviewed changes
.../commons/common-utils/src/main/java/com/tencent/bk/job/common/util/FilePathValidateUtil.java Outdated

// 路径中有合法的内置变量或全局变量通过校验
if (validateVariable(path)) {
log.warn("The path {} contains legal variables", path);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 不应该用warn，这里表示校验路径通过
  2. 这个日志建议删除

.../commons/common-utils/src/main/java/com/tencent/bk/job/common/util/FilePathValidateUtil.java Outdated
}
if (!result) {
// 路径不合法
log.error("The path {} is invalid and the verification fails", path);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使用warn级别即可，这个不是系统错误

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangyu096 wangyu096 wangyu096 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liuliaozhong @wangyu096