Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: 添加删除定时任务的ESB/APIGW接口 #2733 #2737

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

liuliaozhong
Copy link
Collaborator

No description provided.

/**
* 定时作业 ID
*/
@NotEmpty(message = "{validation.constraints.CronId_empty.message}")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缺少对应的国际化资源

Copy link
Collaborator

@jsonwan jsonwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1个小问题需要处理,此外,请补充api-gateway接口文档

@@ -47,6 +47,7 @@ validation.constraints.InvalidHighRiskRegularStatus.message=Invalid High-risk ex
validation.constraints.InvalidHighRiskRegularDescription_outOfLength.message=High-risk explanation description can not exceed {max} characters
validation.constraints.InvalidBkBizId.message=Invalid bk_biz_id
validation.constraints.InvalidCronId.message=Invalid id
validation.constraints.CronId_empty.message=Cron id cannot be empty
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty还是改成null吧,与NotNull对应起来

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

Copy link
Collaborator

@jsonwan jsonwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty改为null

@jsonwan jsonwan merged commit a7e1878 into TencentBlueKing:master Jan 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants