fix: 大业务下执行历史首页记录数量偶现只有一行 #3182 #3183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
交换count与select的顺序，缓解问题。
wangyu096
requested changes
Sep 4, 2024
| if (baseSearchCondition.isCountPageTotal()) { | ||
| count = getPageTaskInstanceCount(taskQuery); | ||
| if (count == 0) { | ||
| return PageData.emptyPageData(start, length); |
There was a problem hiding this comment.
这个数量=0，直接返回的逻辑需要补上。可以判断 result.size()
There was a problem hiding this comment.
result.size()==0并不代表数据为空，有可能是start超出了数据总量，count还是需要查一次的。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
交换count与select的顺序，缓解问题。