fix: 更新过程中服务间调用失败导致无损更新失效 #3242 #3244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jsonwan
commented
Oct 11, 2024
jsonwan
commented
- 打印负载均衡实例获取记录，用于分析可能存在的缓存未刷新原因；
- 打印FeignClient调用失败时的真实URL信息用于排查问题；
- 调整GracefulShutdown等待时间为40s，避免边界误差导致负载均衡缓存未刷新；
- 修复开发过程中发现的gradle task renameArtifacts的不合理依赖关系。
调整GracefulShutdown等待时间，观察负载均衡缓存刷新情况。
打印负载均衡实例获取记录，分析缓存未刷新原因。
打印负载均衡实例获取记录，分析缓存未刷新原因。
1.打印FeignClient调用失败时的真实URL信息用于排查问题； 2.打印负载均衡实例获取记录日志。
1.调整GracefulShutdown等待时间为40s，避免边界误差导致负载均衡缓存未刷新。
1.抽取配置至公共模块，应用于所有服务。
1.修复非k8s模式编译失败问题。
wangyu096
requested changes
Oct 11, 2024
| @Override | ||
| public List<ServiceInstance> getInstances(String serviceId) { | ||
| List<ServiceInstance> serviceInstanceList = super.getInstances(serviceId); | ||
| log.debug("serviceId={}, serviceInstanceList={}", serviceId, serviceInstanceList); |
There was a problem hiding this comment.
isDebugEnabled 需要加上， 避免 ServiceInstance.toString 调用
| @AutoConfigureAfter({KubernetesClientAutoConfiguration.class}) | ||
| @EnableConfigurationProperties(KubernetesDiscoveryProperties.class) | ||
| public class JobK8sDiscoveryClientAutoConfiguration { | ||
|
|
There was a problem hiding this comment.
- 直接覆盖原始框架自动装配的方式，在后续框架升级版本变更中容易遗忘“同步原始代码”这个步骤，建议在注释代码中加上注意事项，以免后面忘记了
- 保险期间，可以覆盖完整，尽可能保留原框架的设计。这里少了 KubernetesDiscoveryClientHealthIndicatorConfiguration 相关的配置。
1.处理review意见。
wangyu096
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.