feat: 支持目录权限配置 #1579 #1602
Merged
feat: 支持目录权限配置 #1579 #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnlkl
reviewed
Dec 28, 2023
| @@ -188,46 +192,30 @@ open class PermissionServiceImpl constructor( | |||
| // check user admin permission | |||
| if (user.admin) return true | |||
| // check role project admin | |||
| if (checkProjectAdmin(request, user.roles)) return true | |||
| if (checkProjectAdmin(request)) return true | |||
| // check role project user | |||
| if (checkProjectUser(request, user.roles)) return true | |||
There was a problem hiding this comment.
这里只要是项目成员就不会再继续判断仓库管理员或是否有Node权限了
...auth/biz-auth/src/main/kotlin/com/tencent/bkrepo/auth/service/local/PermissionServiceImpl.kt
Outdated
Show resolved
Hide resolved
...auth/biz-auth/src/main/kotlin/com/tencent/bkrepo/auth/service/local/PermissionServiceImpl.kt
Outdated
Show resolved
Hide resolved
...auth/biz-auth/src/main/kotlin/com/tencent/bkrepo/auth/service/local/PermissionServiceImpl.kt
Show resolved
Hide resolved
| @@ -30,6 +30,7 @@ | |||
| */ | |||
| dependencies { | |||
| implementation(project(":common:common-api")) | |||
| api(project(":common:common-query:query-api")) | |||
cnlkl
reviewed
Dec 29, 2023
| } | ||
| } else { | ||
| if (it.includePattern.isNotEmpty()) { | ||
| excludePath.addAll(it.includePattern) |
There was a problem hiding this comment.
这里需要过滤用户有权限的路径，不加入到excludePath中
cnlkl
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.