feat: 支持websocket #2494 #2514
Open
feat: 支持websocket #2494 #2514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaoxuwan
force-pushed
the
issue_2494
branch
14 times, most recently
from
71d3931
to
06fe8fb
Compare
cnlkl
requested changes
Sep 2, 2024
| } | ||
|
|
||
| override fun registerStompEndpoints(registry: StompEndpointRegistry) { | ||
| registry.addEndpoint(USER_ENDPOINT, APP_ENDPOINT) |
There was a problem hiding this comment.
这里为什么要setAllowedOriginPatterns两次
There was a problem hiding this comment.
是两个不同的endpoint，需要单独设置
...bsocket/biz-websocket/src/main/kotlin/com/tencent/bkrepo/websocket/handler/SessionHandler.kt
Show resolved
Hide resolved
yaoxuwan
force-pushed
the
issue_2494
branch
2 times, most recently
from
17f5be0
to
ef2e5ba
Compare
cnlkl
reviewed
Sep 5, 2024
| logger.warn("this session[$sessionId] already in cacheSession") | ||
| return | ||
| } | ||
| cacheSessionList.add(sessionId) |
There was a problem hiding this comment.
这边contains与add两个操作在并发执行时会不会导致重复添加
yaoxuwan
force-pushed
the
issue_2494
branch
2 times, most recently
from
94a2dd7
to
098afd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.