Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Use embed instead of packr2 #131

Merged
merged 10 commits into from
Oct 26, 2023

Conversation

ifooth
Copy link
Member

@ifooth ifooth commented Oct 22, 2023

issue: #130

Copy link
Collaborator

@tming tming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

基本功能看上去是正常的,后面还需要对比下性能,确认下性能不受影响

@ifooth
Copy link
Member Author

ifooth commented Oct 25, 2023

benchmark

image

@ifooth
Copy link
Member Author

ifooth commented Oct 25, 2023

benchmark code

/*
 * Copyright (c) 2021 THL A29 Limited, a Tencent company. All rights reserved
 *
 * This source code file is licensed under the MIT License, you may obtain a copy of the License at
 *
 * http://opensource.org/licenses/MIT
 *
 */

package static

import (
	"io"
	"testing"

        // slower
	// _ "github.com/TencentBlueKing/bk-turbo/src/backend/booster/bk_dist/dashboard/static/packrd"
	"github.com/gobuffalo/packr/v2"
)

func BenchmarkStatsFS(b *testing.B) {
	staticFS, err := StatsFS()
	if err != nil {
		panic(err)
	}

	for i := 0; i < b.N; i++ {
		f, err := staticFS.Open("index.html")
		if err != nil {
			panic(err)
		}

		_, err = io.Copy(io.Discard, f)
		if err != nil {
			panic(err)
		}
	}
}

func BenchmarkPackr2(b *testing.B) {
	box := packr.New("dashboard_box", "./stats")

	for i := 0; i < b.N; i++ {
		f, err := box.Open("index.html")
		if err != nil {
			panic(err)
		}

		_, err = io.Copy(io.Discard, f)
		if err != nil {
			panic(err)
		}
	}
}

@tming tming merged commit 9766210 into TencentBlueKing:master Oct 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants