-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Use embed instead of packr2 #131
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifooth
force-pushed
the
dev-joelei-embed
branch
from
October 25, 2023 05:17
a83f934
to
42a8682
Compare
tming
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
基本功能看上去是正常的,后面还需要对比下性能,确认下性能不受影响
benchmark code /*
* Copyright (c) 2021 THL A29 Limited, a Tencent company. All rights reserved
*
* This source code file is licensed under the MIT License, you may obtain a copy of the License at
*
* http://opensource.org/licenses/MIT
*
*/
package static
import (
"io"
"testing"
// slower
// _ "github.com/TencentBlueKing/bk-turbo/src/backend/booster/bk_dist/dashboard/static/packrd"
"github.com/gobuffalo/packr/v2"
)
func BenchmarkStatsFS(b *testing.B) {
staticFS, err := StatsFS()
if err != nil {
panic(err)
}
for i := 0; i < b.N; i++ {
f, err := staticFS.Open("index.html")
if err != nil {
panic(err)
}
_, err = io.Copy(io.Discard, f)
if err != nil {
panic(err)
}
}
}
func BenchmarkPackr2(b *testing.B) {
box := packr.New("dashboard_box", "./stats")
for i := 0; i < b.N; i++ {
f, err := box.Open("index.html")
if err != nil {
panic(err)
}
_, err = io.Copy(io.Discard, f)
if err != nil {
panic(err)
}
}
} |
ifooth
force-pushed
the
dev-joelei-embed
branch
from
October 25, 2023 11:55
11eae6b
to
7733c90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #130