fix: 审计支持失败记录 #71 #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Canway-shiisa
force-pushed
the
development
branch
from
94fdbe6
to
6ea9188
Compare
IMBlues
reviewed
Sep 29, 2021
Canway-shiisa
force-pushed
the
development
branch
from
c16a420
to
bb6d4a6
Compare
Canway-shiisa
force-pushed
the
development
branch
from
bb6d4a6
to
bb6213e
Compare
Open
…into development
…into development
IMBlues
reviewed
Oct 21, 2021
IMBlues
reviewed
Oct 21, 2021
src/api/bkuser_core/audit/migrations/0004_auto_20210926_1914.py
Outdated
Show resolved
Hide resolved
Canway-shiisa
force-pushed
the
development
branch
2 times, most recently
from
1a339e9
to
d59176c
Compare
Canway-shiisa
force-pushed
the
development
branch
from
d59176c
to
2efab88
Compare
IMBlues
approved these changes
Oct 26, 2021
| def catch_exc(func): | ||
| def _catch_exc(self, request, *args, **kwargs): | ||
| try: | ||
| func(self, request, *args, **kwargs) |
There was a problem hiding this comment.
这里没有返回正常的 Response，后续的异常没有继续 raise 来返回异常的 Response 😕
There was a problem hiding this comment.
可以看看这个 mr #127 应该解决了这个问题，有空的话也可以帮忙 review 一下。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.