fix: 沙箱应用进程会根据 app_desc 改变 #1711
Open
+349
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesgetx
reviewed
Nov 7, 2024
| @@ -199,6 +205,12 @@ func parseDeployStepOpts(oldDir, newDir string) *deployStepOpts { | |||
| eq, err := utils.SortedCompareFile(oldFilePath, newFilePath) | |||
| if err != nil || !eq { | |||
| rebuild = true | |||
| // metaDataRebuildFiles 中的文件被修改时, 需要删除 metadata.toml, 以便生成最新的 metadata.toml | |||
| if slices.Contains(metaDataRebuildFiles, fileName) { | |||
| if err := os.Remove(path.Join(devsandbox.DefaultLayersDir, "config", "metadata.toml")); err != nil { | |||
There was a problem hiding this comment.
直接用 launch.GetMetadataFilePath(devsandbox.DefaultLayersDir) 获取 metadata.toml 路径
There was a problem hiding this comment.
这里的逻辑很奇怪，parseDeployStepOpts 不应该有删除文件的副动作。正常情况下，我们不应该去维护 metadata.toml。建议搞清楚原因再实现
| buildDependentFiles := []string{"requirements.txt", "Aptfile", "runtime.txt", "Procfile"} | ||
| func parseDeployStepOpts(oldDir, newDir string) (*deployStepOpts, error) { | ||
| buildDependentFiles := []string{"requirements.txt", "Aptfile", "runtime.txt", "Procfile", "app_desc.yaml"} | ||
| metaDataRebuildFiles := []string{"Procfile", "app_desc.yaml"} |
There was a problem hiding this comment.
rebuild 会受到 app_desc.yaml 哪个配置的影响？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.