refactor: tidy codes

Signed-off-by: Jack Cherng <[email protected]>

plugin/ui/chat.py

@@ -126,11 +126,8 @@ def conversation(self, value: list[CopilotPayloadConversationEntry]) -> None:
     # normal methods #
     # -------------- #
 
-    def __init__(self, window: sublime.Window | None) -> None:
-        if not window:
-            raise ValueError("window is required")
-
-        self.window: sublime.Window = window
+    def __init__(self, window: sublime.Window) -> None:
+        self.window = window
 
     def reset(self) -> None:
         self.is_waiting = False
@@ -181,8 +178,8 @@ def close(self) -> None:
 
 class _ConversationEntry:
     def __init__(self, window: sublime.Window) -> None:
-        self.window: sublime.Window = window
-        self.wcm: WindowConversationManager = WindowConversationManager(window)
+        self.window = window
+        self.wcm = WindowConversationManager(window)
 
     @property
     def completion_content(self) -> str:

plugin/utils.py

@@ -111,25 +111,15 @@ def fix_completion_syntax_highlight(view: sublime.View, point: int, code: str) -
     return code
 
 
-def get_copilot_setting(
-    instance: sublime.Window | sublime.View | None, prefix: str, key: str, default: Any = None
-) -> Any:
-    if not instance:
-        return
+def get_copilot_setting(instance: sublime.Window | sublime.View, prefix: str, key: str, default: Any = None) -> Any:
     return instance.settings().get(f"{prefix}.{key}", default)
 
 
-def set_copilot_setting(
-    instance: sublime.Window | sublime.View | None, prefix: str, key: str, default: Any = None
-) -> Any:
-    if not instance:
-        return
+def set_copilot_setting(instance: sublime.Window | sublime.View, prefix: str, key: str, default: Any = None) -> Any:
     instance.settings().set(f"{prefix}.{key}", default)
 
 
-def erase_copilot_setting(instance: sublime.Window | sublime.View | None, prefix: str, key: str) -> Any:
-    if not instance:
-        return
+def erase_copilot_setting(instance: sublime.Window | sublime.View, prefix: str, key: str) -> Any:
     instance.settings().erase(f"{prefix}.{key}")