Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎊 Copilot Chat #168

Merged
merged 75 commits into from
Jul 3, 2024
Merged

🎊 Copilot Chat #168

merged 75 commits into from
Jul 3, 2024

Conversation

TerminalFi
Copy link
Owner

@TerminalFi TerminalFi commented Jun 19, 2024 •
edited
Loading

Current status

TerminalFi 2024-07-02 at 15 29 07@2x

@TerminalFi TerminalFi linked an issue Jun 19, 2024 that may be closed by this pull request
Will it be possible to accommodate Copilot X's chat interface? #99
Closed
@jfcherng jfcherng mentioned this pull request Jun 19, 2024
Closed
@jfcherng
Copy link
Collaborator

About handling $/progress, sublimelsp/LSP#2494

@jfcherng jfcherng mentioned this pull request Jun 21, 2024
Closed
@dependabot @jfcherng
chore(deps): bump copilot-node-server from 1.36.0 to 1.37.0 in /langu…
745cd5f 
…age-server (#172)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@jfcherng jfcherng added the enhancement New feature or request label Jun 21, 2024
@jfcherng
Copy link
Collaborator

jfcherng commented Jul 2, 2024

image

@jfcherng
Copy link
Collaborator

jfcherng commented Jul 2, 2024 •
edited
Loading

  1. It also keep auto filling chat question for me 🤔
  2. What should happen if the user asks a new question (can he?) while the current one has not finished yet?

@jfcherng
make CI happy
69388ac 
Signed-off-by: Jack Cherng <[email protected]>
@TerminalFi
Copy link
Owner Author

  1. That's copilot suggested follow up. Probably need different approach 😀
  2. Yea, will have to check how vscode does it

@TerminalFi
Copy link
Owner Author

image

I think these are both fixed in latest

@TerminalFi
Copy link
Owner Author

I'm still working on the other two

  1. Auto fill with suggested next question
  2. What to do when asking while waiting

@TerminalFi
Copy link
Owner Author

I'm still working on the other two

  1. Auto fill with suggested next question
  2. What to do when asking while waiting
  1. Follow up is a link at the base of the chat panel
  2. We now prevent user submitting a new question while awaiting the next question. This is inline with VS Code

@TerminalFi
Copy link
Owner Author

The refactor is beautiful

@TerminalFi TerminalFi merged commit ffda250 into master Jul 3, 2024
2 checks passed
@jfcherng jfcherng deleted the impl/Chat branch July 4, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfcherng jfcherng jfcherng left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Will it be possible to accommodate Copilot X's chat interface?
2 participants
@TerminalFi @jfcherng