Bug fix in SftpFileWriter and increased version constraints #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped SDK constraints from
">=2.17.0 <3.0.0"
up to">=2.17.0 <4.0.0"
Bug fix in
SftpFileWriter
for #50, #71, #100:When the input stream contains only one event and that event has fewer bytes than
maxBytesOnTheWire
, then theSftpFileWriter._doneCompleter
never got completed. This happened because the completer got only completed in the_handleLocalData
event handler if the_streamDone
flag was already true, the problem is that if the stream only has one small event, then_handleLocalData
will only be called once with the event and afterward_handleLocalDone
will be called once, which sets_streamDone
to true. At this point the_doneCompleter
cannot be completed anymore because the_handleLocalData
will not get called anymore. This problem causes never endingawait
statements when opening and writing a file.This issue has been fixed by checking if all sent bytes have already been acknowledged in the
_handleLocalDone
event handler and subsequently completing the_doneCompleter
.Added return type
SftpFileOpenMode
to operator|
in classSftpFileOpenMode
. Fix for #80.