Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync ShortcutManager's shortcuts in didUpdateWidget #140

Merged
merged 1 commit into from
Oct 23, 2022

Conversation

jpnurmi
Copy link
Contributor

@jpnurmi jpnurmi commented Oct 21, 2022

If TerminalView is rebuilt with a different set of shortcuts, make sure to pass them to ShortcutManager.

@xtyxtyx xtyxtyx self-assigned this Oct 21, 2022
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #140 (d4d0ba7) into master (cb0de8b) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
- Coverage   51.41%   51.39%   -0.02%     
==========================================
  Files          50       50              
  Lines        3262     3263       +1     
==========================================
  Hits         1677     1677              
- Misses       1585     1586       +1     
Impacted Files Coverage Δ
lib/src/terminal_view.dart 67.05% <0.00%> (-0.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@xtyxtyx xtyxtyx merged commit c626ceb into TerminalStudio:master Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants